Fix surrogate PK ordering #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When performing LQ on a table without PKs, we need to ensure that the surrogate PKs that we use (the string representation of the entire row) is properly ordered. Otherwise we will end up with some objects being wrongly categorised as singletons as opposed to being grouped together, which will lead to wrong query results.
If MINIO_CI_CD is not to true Minio container just exits with "Error: Disk `/tmp` is part of root disk, will not be used" and all related tests fail. In addition change the deprecated cred env var names.
gruuya
commented
Jun 3, 2022
| @@ -166,7 +169,7 @@ def checkout(self, force: bool = False, layered: bool = False) -> None: | |||
| self.object_engine.delete_table(target_schema, table) | |||
|
|
|||
| if layered: | |||
| self.lq_checkout() | |||
| self.lq_checkout(ddn_layout=ddn_layout) | |||
There was a problem hiding this comment.
Since we've split the read and write shim schemas there's no use in having different overlay layout between cli (_sgov_lower_my_table foreign table, my_table view, _sgov_upper_my_table helper table) and ddn (my_table foreign table, _sgov_merged_my_table view, _sgov_upper_my_table helper table) now in theory.
Even if we decide to try and re-use those schemas to serve up some reads from them, we would need to keep track of the dirty tables. Since the target table is a dirty table (changed after executing the write), we would need to re-mount a clean shim schema anyway.
mildbyte
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing LQ on a table without PKs, we need to ensure that the surrogate PKs that we use
(the string representation of the entire row) is properly ordered. Otherwise we will end up with some
objects being wrongly categorised as singletons as opposed to being grouped together, which will
lead to wrong query results.