Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gracefully handle unstarted experiments in #finish helper method #26

Closed
ghost opened this issue Nov 8, 2011 · 1 comment
Closed

Gracefully handle unstarted experiments in #finish helper method #26

ghost opened this issue Nov 8, 2011 · 1 comment

Comments

@ghost
Copy link

ghost commented Nov 8, 2011

When you add a new experiment to your code and deploy there is a currently a race condition.

If one of your visitors triggers the finish helper for the experiment before one of your visitors triggers the creation of the experiment then the finish method raises an exception.

Split should handle this without raising an exception.
@mocoso mocoso mentioned this issue Nov 8, 2011
Merged
@andrew
Copy link
Member

andrew commented Nov 8, 2011

Fixed with #27

@andrew andrew closed this as completed Nov 8, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andrew