Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug infinite version when metadata is cleared #514

Closed
antulik opened this issue Feb 17, 2018 · 0 comments · Fixed by #633
Closed

Bug infinite version when metadata is cleared #514

antulik opened this issue Feb 17, 2018 · 0 comments · Fixed by #633

Comments

@antulik
Copy link

antulik commented Feb 17, 2018

Related to:

redis.set(metadata_key, @metadata.to_json) unless @metadata.nil?

To reproduce.

  1. Create and save Split::Experiment with some metadata
  2. Initialise and save the same experiment but with metadata: nil
    -> During save experiment version will increment
  3. Initialise the same experiment as in step 2 (with metadata: nil) and save experiment
    -> During save experiment version will increment

Expected:

In step 3 the version should not be incremented because experiment configuration has not changed after step 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant