Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db_failover fails using Redis 3.0.1 #59

Closed
dv opened this issue Jul 3, 2012 · 0 comments
Closed

db_failover fails using Redis 3.0.1 #59

dv opened this issue Jul 3, 2012 · 0 comments

Comments

@dv
Copy link
Contributor

dv commented Jul 3, 2012

I'm using Redis 3.0.1. When a redis connection is refused, it throws a Redis::CannotConnectError exception, not a ECONNREFUSED exception, therefore it still bubbles upwards and kills the app.

I suggest using a catch-all exception handler when db_failover is enabled, since it's quite important for production systems to "keep calm and carry on" and I don't want to check all possible exceptions this and future Redis could throw (Timeout exceptions? Peer disconnected exceptions?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants