If the url is not conform to date-based archiving, this unexpectedly wouldn't lead to an error. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: core/components/articles/model/articles/article.class.php
Updated and merged to current HEAD from origin:develop
…m on to Archivist
|
It looks like these were never merged with Articles, which is now moved to modxcms/Articles |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this today, as some weird urls showed up in the google index for one of my projects.
Since ArticlesRouter just passes the parameters through, the ArticlesContainer would always fall back to interpreting the request as an archive (even if a resource with this url doesn't exist and the parameters don't have anything in common with dates). As a result MODx will always return a HTTP 200 status, which is really bad.
To fix this, we have to validate the parameters for numeric values and return false if they are invalid.