-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modx 2.3 Compatibility #285
Comments
It looks like the javascript issue on the album page might be in the file: /assets/components/gallery/js/mgr/widgets/album/albums.items.view.js A possible fix might be found in a pull request from a similar extension: https://github.com/bezumkin/ms2Gallery/commit/ac6e882b0e67c1a9f807f60f967337068101cfaf |
I posted the compatibility fix here: modxcms#39 It looked like it was the active branch. |
The Thumbnail view in Gallery manager is broken in my 2.3.1 installation. Every phpthumb-URL starts with an "0", like here: If I manually delete the 0 from the src attribute, the picture shows fine: But I did not find the place where the 0 is getting added... |
Hi |
Any news on this? Who is picking this up? |
yes - please help to fix the gallery! |
In version 2.3.1 the front end works perfectly, but the manager page is not working right. If I add return; to the end of the connector file (/assets/components/gallery/connector.php) the manager page loads without javascript errors, but there is probably a better way of using the main connector in 2.3.
I was also able isolate the css that was dropped from the default mananger theme:
/From Modx 2.2.14 index.css line 1784-1859 */
.modx-pb-view-ct {
background: white;
font: 11px Arial, Helvetica, sans-serif;
}
.modx-pb-thumb{
border: 1px solid #dddddd;
padding: 5px;
height: 80px;
width: 100px;
line-height: 80px;
text-align: center;
}
.modx-pb-thumb img{
vertical-align: middle;
}
.modx-pb-thumb-wrap {
float: left;
margin: 4px 0 4px 4px;
padding: 4px;
overflow: hidden;
border: 1px solid transparent;
}
.modx-pb-thumb-wrap span{
display: block;
overflow: hidden;
text-align: center;
}
.modx-pb-view-ct .x-view-over{
/ border:1px solid #dddddd;/
/ padding: 4px;_/
}
.modx-pb-view-ct .x-view-selected{
background: #DFEDFF;
border: 1px solid #6593cf;
/_padding: 4px;*/
}
.modx-pb-view-ct .x-view-selected .thumb{
background: transparent;
}
.modx-pb-view-ct .x-view-selected span{
color: #1A4D8F;
}
.modx-pb-view-ct .loading-indicator {
font-size: 11px;
background-repeat: no-repeat;
background-position: left;
padding-left: 20px;
margin: 10px;
}
.modx-pb-detail-thumb {
margin-top: 5px;
text-align: center;
cursor: pointer;
}
.modx-pb-details-info {
border-top: 1px solid #cccccc;
font: 11px Arial, Helvetica, sans-serif;
padding: 5px;
margin-top: 5px;
text-align: left;
}
.modx-pb-details-info b {
color: #555555;
display: block;
margin-bottom: 4px;
}
.modx-pb-details-info span{
display: block;
margin-bottom: 5px;
margin-left: 5px;
}
.modx-pb-fullview {
text-align: center;
}
As a quick fix, I appended this at the end of the 2.3.1 file: /manager/templates/default/index.css
The layout looked right again once this css was added. Though the new media manager may have new css classes.
There are still some problems with the javascript files on the update album page in the manager. The menu option to update or delete is not working, and the sort feature is also broken. The error I get is "Cannot read property 'viewIndex' of undefined".
The text was updated successfully, but these errors were encountered: