Added Comment Sort Direction #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Comment Sort Direction setting to Advanced Settings > Comments - Display Functions similar to General Sort Direction (ASC or DESC) This setting is passed to Quip allowing the content administrator to control the order comments are displayed in on their Article pages Lexicons have been updated to contain this setting http://j4p.us/image/3p0H1n302K2I Signed-off-by: JP DeVries <johnpaul.devries@gmail.com>
|
I just realized that container.common.js I mistakenly left the default value for setting_commentsSortDir 'DESC' whereas it should be 'ASC'. |
theboxer
referenced
this pull request
in theboxer/Articles
Aug 4, 2013
Fixed sorting articles in grid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Comment Sort Direction setting to Advanced Settings > Comments - Display
Functions similar to General Sort Direction (ASC or DESC)
This setting is passed to Quip allowing the content administrator to control the order comments are displayed in on their Article pages
Lexicons have been updated to contain this setting
Let me know if there's anything I can do such additional testing cases.
Screenshot of new setting:
http://j4p.us/image/3p0H1n302K2I
Signed-off-by: JP DeVries johnpaul.devries@gmail.com