Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Polkadot v0.8.28 #50

Merged
merged 2 commits into from Apr 24, 2021
Merged

Support for Polkadot v0.8.28 #50

merged 2 commits into from Apr 24, 2021

Conversation

pablojorge
Copy link
Contributor

This PR adds support for two changes introduced in v0.8.28 (https://github.com/paritytech/polkadot/releases/tag/v0.8.28):

A new MultiAddress class that takes the place and wraps the original Address is introduced. The BalanceTransfer and Extrinsic classes now contain a reference to a MultiAddress, and for backward compatibility, we keep setters that accept a plain Address instance.

@codecov-io
Copy link

Codecov Report

Merging #50 (5d09ba6) into master (b2d8775) will increase coverage by 0.13%.
The diff coverage is 94.44%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #50      +/-   ##
============================================
+ Coverage     86.91%   87.04%   +0.13%     
- Complexity      892      911      +19     
============================================
  Files           115      118       +3     
  Lines          2973     3034      +61     
  Branches        430      438       +8     
============================================
+ Hits           2584     2641      +57     
  Misses          278      278              
- Partials        111      115       +4     
Impacted Files Coverage Δ Complexity Δ
.../io/emeraldpay/polkaj/scaletypes/MultiAddress.java 87.50% <87.50%> (ø) 2.00 <2.00> (?)
...in/java/io/emeraldpay/polkaj/scale/UnionValue.java 94.44% <87.50%> (-5.56%) 12.00 <7.00> (+7.00) ⬇️
...a/io/emeraldpay/polkaj/scaletypes/AccountInfo.java 100.00% <100.00%> (ø) 17.00 <5.00> (+3.00)
...meraldpay/polkaj/scaletypes/AccountInfoReader.java 100.00% <100.00%> (ø) 2.00 <0.00> (ø)
.../emeraldpay/polkaj/scaletypes/BalanceTransfer.java 74.07% <100.00%> (+2.07%) 15.00 <1.00> (+1.00)
...ldpay/polkaj/scaletypes/BalanceTransferReader.java 100.00% <100.00%> (ø) 2.00 <0.00> (ø)
...ldpay/polkaj/scaletypes/BalanceTransferWriter.java 100.00% <100.00%> (ø) 3.00 <1.00> (+1.00)
...ava/io/emeraldpay/polkaj/scaletypes/Extrinsic.java 93.75% <100.00%> (+0.20%) 11.00 <0.00> (ø)
.../emeraldpay/polkaj/scaletypes/ExtrinsicReader.java 84.37% <100.00%> (ø) 2.00 <0.00> (ø)
.../emeraldpay/polkaj/scaletypes/ExtrinsicWriter.java 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2d8775...5d09ba6. Read the comment docs.

@splix
Copy link
Owner

splix commented Apr 24, 2021

@pablojorge sorry, totally missed the Pull Request. Just checked it, everything looks good, and I'm going to merge it now. Thank you!

@splix splix merged commit 7282859 into splix:master Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants