2016 04 stze result api call #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
August 26, 2016 19:27
|
@mkind i'll hand over this PR and branch to you. If you'll find some problems, would be great if you could fix them, otherwise please merge into master. |
…fno-sanitize-recover=undefined,integer
…detailed error message
validation functions to validate sent requests and sent responses. In addition to that, the test message are all built by the same method. So no more redundant code in all dispatcher tests.
breaks the khashmap_get in connection_send_request.
…ver w/ -fno-sanitize-recover=undefined,integer" This reverts commit 456a6ad.
stze
commented
Sep 29, 2016
| @@ -327,13 +329,13 @@ endif() | |||
|
|
|||
| if(CLANG_ADDRESS_SANITIZER) | |||
| set_property(TARGET sb APPEND_STRING PROPERTY COMPILE_FLAGS "-DEXITFREE ") | |||
| set_property(TARGET sb APPEND_STRING PROPERTY COMPILE_FLAGS "-fno-sanitize-recover -fno-omit-frame-pointer -fno-optimize-sibling-calls -fsanitize=address -fsanitize=undefined ") | |||
| set_property(TARGET sb APPEND_STRING PROPERTY COMPILE_FLAGS "-fno-sanitize-recover=undefined,integer -fno-omit-frame-pointer -fno-optimize-sibling-calls -fsanitize=address -fsanitize=undefined ") | |||
There was a problem hiding this comment.
this change seems reasonable, but it reverts an old commit where this option was disabled. travis clang is old and doesn't support undefined,integer yet.
| @@ -68,9 +68,12 @@ int api_result(char *targetpluginkey, uint64_t callid, | |||
| cinfo = connection_send_request(targetpluginkey, result, result_params, | |||
| api_error); | |||
|
|
|||
| if (true == api_error->isset) | |||
There was a problem hiding this comment.
why not:
if(api_error->isset) and
if(!api_error->isset) instead of
if(true == api_error->isset) and
if(false == api_error->isset) 
| if (!p || !f) | ||
| LOG_ERROR("[test] Failed to alloc mem for example plugin.\n"); | ||
|
|
||
| p->key = cstring_copy_string("0123456789ABCDEF"); |
There was a problem hiding this comment.
would be nice to allocate all these strings on the stack. maybe we can change it to:
p->key = (string) {.str = "0123456789ABCDEF", .length = sizeof("0123456789ABCDEF") - 1}};then we can remove the free_string calls in the helper_free_plugin function.
There was a problem hiding this comment.
This might be a general approach to save some heap allocs in other contexts too.
plugins without providing rpc calls itself. This is reasonable for different kinds of UI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the result api call. You can test this by using
2016-05-bontric-implement-result-callpython client branch.