Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Alert Muting Rule #360

Merged
merged 2 commits into from
Mar 18, 2022
Merged

Conversation

luke-sterkowicz
Copy link
Collaborator

  • Allowing fake delete of alert muting rules in the past (API limitation that causes invalid terraform state) - this was requested by customers
  • Making 'filter' set optional - at least one filter is required by the API, however introducing the 'detectors' list makes the requirement for 'filter' set obsolete. For the cases where we have only 'detector' filter, terraform still would require 'filter' to be set. Workaround by placing the detector in 'filter' set is not perfect as it will cause conversions underneath and unnecessary updates on every terraform apply.

Copy link
Collaborator

@keitwb keitwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, seems like a reasonable workaround.

@luke-sterkowicz luke-sterkowicz merged commit 7e67646 into main Mar 18, 2022
@atoulme atoulme deleted the splunk/fix_alert_muting_rule branch May 2, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants