fix: group name can't start with a number #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 This PR is included in version 1.0.0-beta.11 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
wojtekzyla
added a commit
that referenced
this pull request
Oct 4, 2023
* fix: refactor routes in flask, refactor InventoryList.jsx, change delete button in delete modal to primary, after deleting anything always display confiramtion, change label on the button in the inventory, add a unit to the polling frequency fix: display config from the inventory for the devices in groups fix: unfinished validation of new hosts and group fix: validation of new devices and groups fix: comment out obsolete test - they will be updated while creating test suit * fix: add permissions to the release job in workflow fix: combine frontend and bacnkend build to one workflow, create release workflow fix: run build frontent and backend in seperate jobs fix: don't build pr images fix: update .releaserc * Update ci-build.yaml Don't push docker images in ci-build.yaml workflow Revert "Update ci-build.yaml" This reverts commit 2e57423. fix: change yarn network-timeout fix: Don't push docker images in ci-build.yaml workflow, don't update yarn network-timeout fix: install python in frontend docker image fix: install python3 on alpine linux fix: add make in frontend Dockerfile fix: rename workflow name to ci-build fix: frontend dockerfile install python2 fix: dockerfile change * fix: fix invalid escape sequence \s in .releaserc * fix: remove extra quotation mark in .releaserc * fix: update .releaserc * fix: update .releaserc * fix: fix matches in .releaserc * chore(release): 1.0.0-beta.1 # 1.0.0-beta.1 (2023-07-05) ### Bug Fixes * add collapsible rows in profiles ([23035bb](23035bb)) * add gunicorn logger, add test directory, add requirements ([1ba2cad](1ba2cad)) * add permissions to the release job in workflow ([71cec71](71cec71)) * add SC4SNMP_UI_backend directory in backend Dockerfile ([fa35651](fa35651)) * add validation to check if community is provided if version is 1 or 2c ([816c8a8](816c8a8)) * added comments and deleted profile validation context ([f2adcda](f2adcda)) * added error style to inventory and groups forms while validating ([abbda32](abbda32)) * added Proxima Nova font, finished inventory ([6d56473](6d56473)) * added requirements.txt ([d8eb307](d8eb307)) * added semicolon ([6f336ba](6f336ba)) * adding inventory fields without base and mandatory profiles ([2b28113](2b28113)) * auto refresh state after deleting or adding profile ([6e1da8c](6e1da8c)) * automatically add base and mandatory profiles to the new inventory, delete inventory records ([7851aa7](7851aa7)) * backend for delete and edit objects by ID instead of profile name ([87ef861](87ef861)) * bolded header in the inventory modal ([9f9e6ad](9f9e6ad)) * change backendHost to use it on local machine ([e6b11de](e6b11de)) * change docker image repository name ([053e6b7](053e6b7)) * change modal name to Edit or Add depending on action ([4a01627](4a01627)) * change order of menu tabs, change 'IP address/Group' field from group devices configuration to 'IP address' ([156fc6d](156fc6d)) * change organisation of files ([c129eb1](c129eb1)) * change url link of inventory to the updated version of API endpoints ([b8bcc77](b8bcc77)) * changed the way of accesing colection in endpoints, changed how updates of profiles are made, created check_if_inventory_can_be_added, changed the way of deleting group from inventory when the group was deleted ([cf9f482](cf9f482)) * changed variables names ([a810fd6](a810fd6)) * changin variables including 'Id' in the name from 'myNameID' to 'myNameId' ([095b49c](095b49c)) * condition validation and partially working varBinds validation ([28ca072](28ca072)) * converting profiles between two formats ([6befac7](6befac7)) * create modal for displaying messages from backend ([00138ff](00138ff)) * create new groups column in groups UI ([1bb9e10](1bb9e10)) * cross-origin ([f1946a5](f1946a5)) * delete and edit objects by ID instead of profile name ([75705b7](75705b7)) * delete and update endpoints ([c67b2bc](c67b2bc)) * delete inventory.py file ([bf557ba](bf557ba)) * delete unnecessary logger ([82da626](82da626)) * deleted inventory_old.py ([ef747dd](ef747dd)) * deleting profiles ([24c3417](24c3417)) * display messages from backend when updating inventory and updating group ([dfe6978](dfe6978)) * display messages from backend when updating or deleting profiles ([d917657](d917657)) * don't change values after update window is closed without submiting changes ([4cf7249](4cf7249)) * edit apropriate FormRows.Row in varBinds and Conditions ([0253391](0253391)) * edit inventory records with groups ([67cbbc5](67cbbc5)) * editing and deleting inventory records ([ea80642](ea80642)) * editing and deleting inventory records - backend ([bf463e8](bf463e8)) * error message for security engine - fixed grammar error ([33b1bc8](33b1bc8)) * error message for security engine informing that all the letter must be either upper or lowe case ([2503a51](2503a51)) * finished groups UI ([5bfb791](5bfb791)) * first version of edits ([f49a759](f49a759)) * first version of working group form without validation, refactored delete modal ([f291d15](f291d15)) * first version of working group form without validation, refactored delete modal - backend ([5d8e1ee](5d8e1ee)) * fix invalid escape sequence \s in .releaserc ([be8a89f](be8a89f)) * fix matches in .releaserc ([4710923](4710923)) * fixed bug that made edit instead of new profile after previously editing profile ([1214370](1214370)) * fixed conditions editing ([3281c7b](3281c7b)) * fixed error with adding and deleting conditions' patterns while editing ([45870c9](45870c9)) * fixed error with adding varBinds while editing ([02efd96](02efd96)) * fixed error with deleteing last device from the current page ([25105d9](25105d9)) * fixed error with deleting varBinds ([77609a4](77609a4)) * fixed issue with adding device instead of updating if nothing is changed in updating form ([cbbd2b1](cbbd2b1)) * fixed varBinds validation ([eec377f](eec377f)) * fixed varBinds validation ([f93fdf6](f93fdf6)) * fixed varBinds validation ([952eeb8](952eeb8)) * fixed varBinds validation ([7b0c888](7b0c888)) * fixes of varBinds errors ([7eb0d62](7eb0d62)) * fixing bug in pagination ([be8981c](be8981c)) * flask tests ([60eb305](60eb305)) * get host from environment variable ([83605c1](83605c1)) * groups integration with sc4snmp database ([99c072d](99c072d)) * if profile name is updated or the whole profile is deleted, update corresponding record in the inventory ([f9fd0a8](f9fd0a8)) * improved IPv4 regex ([49c046f](49c046f)) * improved reload after deleting, adding or updating device in group ([49fc9b6](49fc9b6)) * InventoryContext, auto reload Inventory after adding new device ([14acbf8](14acbf8)) * loading inventory from mongo ([7df8cfb](7df8cfb)) * logic for inventory validation ([60de7a3](60de7a3)) * logic for profiles validation ([373747f](373747f)) * more options in profile condition selection ([9f4ba5b](9f4ba5b)) * more post endpoint tests ([914b241](914b241)) * move error styles to the seperate file ([40b5917](40b5917)) * new menu, unfinished header ([f1b249b](f1b249b)) * pagination - backend ([e27e327](e27e327)) * pagination of group devices ([18ad840](18ad840)) * pagination of groups and inventory - backend ([5246cd8](5246cd8)) * pagination of inventory ([951208d](951208d)) * pagination with selection of devices per page ([010c56c](010c56c)) * Patterns validation. Validation of new empty fields not always works ([929e6e7](929e6e7)) * polishing inventory ([8284054](8284054)) * position add and apply buttons, change font size in the menu bar ([bebba11](bebba11)) * refactor ([aca5ded](aca5ded)) * refactor AddProfileModal.jsx ([35f632b](35f632b)) * refactor code and add comments ([0688c29](0688c29)) * refactor routes in flask, refactor InventoryList.jsx, change delete button in delete modal to primary, after deleting anything always display confiramtion, change label on the button in the inventory, add a unit to the polling frequency ([0646361](0646361)) * Refactored inventory.py and basic edit of inventory ([0680781](0680781)) * refactoring ([f6ae9c9](f6ae9c9)) * refactoring backend ([e17ad77](e17ad77)) * refresh updates autoamtically after initial app start ([ff61c7f](ff61c7f)) * remove extra quotation mark in .releaserc ([af58564](af58564)) * remove print ([abb1348](abb1348)) * remove spaces in ValidationStyles.jsx ([4e9b506](4e9b506)) * remove temporary tooltip ([67b69ea](67b69ea)) * removed some logs ([e96b124](e96b124)) * Renamed IP addres in form to IP addres/Group ([31c8cc5](31c8cc5)) * renamed key in devices record from group_id to groupId ([23fd776](23fd776)) * restructure directory ([15ec5a0](15ec5a0)) * run frontend on localhost ([da49efa](da49efa)) * same database for profiles ([608c4b1](608c4b1)) * send default values from ProfilesModal to the database ([4786bba](4786bba)) * set default values for port number and snmp version to empty strings in device configuration in groups ([06fe3dc](06fe3dc)) * set profiles as default page ([e26b508](e26b508)) * state is changed in componentDidUpdate and componentDidMount instead of in render() ([21fa4e1](21fa4e1)) * styling menu bar ([676783c](676783c)) * testing menu tab ([eb09a26](eb09a26)) * testing pagination of inventory ([286b78f](286b78f)) * tooltpis ([6a16dc8](6a16dc8)) * unit tests of conversions ([aa094b2](aa094b2)) * update .gitignore ([b486e9e](b486e9e)) * update .releaserc ([b07613c](b07613c)) * update .releaserc ([6159070](6159070)) * update dependencies ([c01315e](c01315e)) * update device from group id reference ([7642e16](7642e16)) * update dockerfile for backend ([890956f](890956f)) * update form in profiles ([04fff13](04fff13)) * update lerna.json and package.json, delete package-lock.json ([6a10457](6a10457)) * update the way of passing flask IP to the frontend app ([d06d77d](d06d77d)) * updated profiles view (opening collapsible not finished) ([f34525a](f34525a)) * updated urls ([56b8169](56b8169)) * use another collection for ui inventory, send error messages to user if theu want to add inventory record that already exists, send error message when user wants to add nonexistent group to the inventory and send message about deleting record from inventory when user deletes group ([bc5006a](bc5006a)) * use sepereta mongo collection for profiles and groups from ui ([7b405e5](7b405e5)) * validation for adding group with existing name and existing device in the group ([e741db4](e741db4)) * validation messages for Profile Name and Frequency ([e64e630](e64e630)) * Validation of groups ([8ea0bfe](8ea0bfe)) * validation of inventory form ([7a82789](7a82789)) * waraping children with ProfileContext in Manager.jsx ([6030b68](6030b68)) * working on groups ([a61ab32](a61ab32)) * working validation ([e4557bf](e4557bf)) * fix: refactor routes in flask, refactor InventoryList.jsx, change delete button in delete modal to primary, after deleting anything always display confiramtion, change label on the button in the inventory, add a unit to the polling frequency fix: display config from the inventory for the devices in groups fix: unfinished validation of new hosts and group fix: validation of new devices and groups fix: comment out obsolete test - they will be updated while creating test suit * fix: Add apply changes fix: add comments to handle_changes.py and kubernetes_job.py fix: in handle_changes.py: added CheckIfPreviousJobFailed handler, added max retries for job creation, added logging and mongo exception handling in celery task fix: update comment in CheckJobHandler * fix: change gunicorn log-level to info * fix: enable compound indices in profiles and configuration of hosts in the inventory using string address fix: enable compound indices and configuration of string based hosts fix: refactor condition in profiles form fix: in ProfileConversion._backend2ui_map for empty patterns filed return empty list instead of None fix: refactor varBinds form * fix: add conditional profiles fix: add conversion of conditional profiles fix: validate if any varBind, pattern or conditions were added fix: remove filed and patterns columns from profiles screen, rename fileds in profile form fix: rename UI fileds in profiles change conversion to int and float * fix: update semantic-release-action version * fix: update __string_value_to_numeric method * fix: update node version in workflows * fix: downgrade semantic-release-action * fix: downgrade node in workflows * fix: refactor and add new tests for flask backend. fix: refactoring inventory post endpoints tests fix: refactor tests and conversions after rebasing fix: refactor helpers.py, write test for adding groups in the inventory fix: update test_post_inventory and test_conversions, refactor conversions.py fix: in Conditional.jsx rename operation 'equal' to 'equals', in Header.jsx while opening new profile modal set default condition to 'standard' fix: add tests for apply changes functionality * fix: bump semantic_version to 20 and cycjimmy/semantic-release-action to 3.4.2 * fix: bump node-version for semantic release and change extra plugin @google/semantic-release-replace-plugin to jpoehnelt/semantic-release-replace-plugin * fix: change jpoehnelt/semantic-release-replace-plugin to semantic-release-replace-plugin * fix: use semantic-release-replace-plugin@v1.2.0 * fix: bump semantic-release-replace-plugin * fix: use @google/semantic-release-replace-plugin@1.2.5 plugin * fix: use @google/semantic-release-replace-plugin@1.2.0 plugin * fix: use @google/semantic-release-replace-plugin@v1.2.5 plugin * fix: in .releaserc use semantic-release-replace-plugin and in ci-release.yaml semantic-release-replace-plugin@v1.2.4 * fix: in .releaserc use semantic-release-replace-plugin and in ci-release.yaml semantic-release-replace-plugin@1.2.4 * fix: use semantic-release-replace-plugin@1.2.0 * chore(release): 1.0.0-beta.2 # [1.0.0-beta.2](v1.0.0-beta.1...v1.0.0-beta.2) (2023-07-11) ### Bug Fixes * Add apply changes ([f3e450a](f3e450a)) * add conditional profiles ([1e146c9](1e146c9)) * bump node-version for semantic release and change extra plugin @google/semantic-release-replace-plugin to jpoehnelt/semantic-release-replace-plugin ([1fb717b](1fb717b)) * bump semantic_version to 20 and cycjimmy/semantic-release-action to 3.4.2 ([f58270c](f58270c)) * bump semantic-release-replace-plugin ([39992eb](39992eb)) * change gunicorn log-level to info ([4420748](4420748)) * change jpoehnelt/semantic-release-replace-plugin to semantic-release-replace-plugin ([5d1dc3f](5d1dc3f)) * downgrade node in workflows ([d2a1a99](d2a1a99)) * downgrade semantic-release-action ([399726a](399726a)) * enable compound indices in profiles and configuration of hosts in the inventory using string address ([30f6d90](30f6d90)) * in .releaserc use semantic-release-replace-plugin and in ci-release.yaml semantic-release-replace-plugin@1.2.4 ([94bdc57](94bdc57)) * in .releaserc use semantic-release-replace-plugin and in ci-release.yaml semantic-release-replace-plugin@v1.2.4 ([a3122b5](a3122b5)) * refactor and add new tests for flask backend. ([a9dc102](a9dc102)) * refactor routes in flask, refactor InventoryList.jsx, change delete button in delete modal to primary, after deleting anything always display confiramtion, change label on the button in the inventory, add a unit to the polling frequency ([13e48d0](13e48d0)) * update __string_value_to_numeric method ([3f7bbdf](3f7bbdf)) * update node version in workflows ([052582c](052582c)) * update semantic-release-action version ([6604c8f](6604c8f)) * use @google/semantic-release-replace-plugin@1.2.0 plugin ([addccef](addccef)) * use @google/semantic-release-replace-plugin@1.2.5 plugin ([434da60](434da60)) * use @google/semantic-release-replace-plugin@v1.2.5 plugin ([7fbdedb](7fbdedb)) * use semantic-release-replace-plugin@1.2.0 ([9949783](9949783)) * use semantic-release-replace-plugin@v1.2.0 ([5d45a28](5d45a28)) * fix: unit tests of inventory form, refactor contexts * fix: add unit tests for groups forms, add tests for varbinds, smart profile patterns and profile name in profiles form * fix: finish AddProfileModal tests, add test for snmpv3 in the inventory * fix: delete Manager.unit.jsx * chore(release): 1.0.0-beta.3 # [1.0.0-beta.3](v1.0.0-beta.2...v1.0.0-beta.3) (2023-07-18) ### Bug Fixes * add unit tests for groups forms, add tests for varbinds, smart profile patterns and profile name in profiles form ([0a4758c](0a4758c)) * delete Manager.unit.jsx ([cf3088d](cf3088d)) * finish AddProfileModal tests, add test for snmpv3 in the inventory ([2e6dd22](2e6dd22)) * unit tests of inventory form, refactor contexts ([edc60a3](edc60a3)) * fix: add warnings when deleting groups or profiles which are configured in the inventory. No frequency configuration for walk profiles. Default number of presented items changed to 20. fix: change message while deleting profiles. Change what is displayed in Frequency column for walk profiles fix: update tests fix: remove unnecessary print fix: improve logging in handle_changes.py, update config_collection in job insted of in CheckIfPreviousJobFailed fix: fix error in celery job fix: update request message in apply_changes fix: typo in return message fix: fix problem with editing walk profile fix: refactor files and write config from mongo to yaml files on host machine fix: change message in error thrown by SaveConfigToFileHandler * fix: save mongo configuration to values.yaml fix: change directory for temp files fix: add test for edited values.yaml file fix: typos and description of yaml_escape_list function * chore(release): 1.0.0-beta.4 # [1.0.0-beta.4](v1.0.0-beta.3...v1.0.0-beta.4) (2023-07-27) ### Bug Fixes * add warnings when deleting groups or profiles which are configured in the inventory. No frequency configuration for walk profiles. Default number of presented items changed to 20. ([8a6cb01](8a6cb01)) * save mongo configuration to values.yaml ([fb615f6](fb615f6)) * fix: add selectors for tests fix: update frontend unit tests fix: rebase on develop branch fix: add more ui test selectors, delete unused ButtonsModal component * chore(release): 1.0.0-beta.5 # [1.0.0-beta.5](v1.0.0-beta.4...v1.0.0-beta.5) (2023-07-27) ### Bug Fixes * add selectors for tests ([f025b9c](f025b9c)) * fix: stay on the same page after refreshing the browser * chore(release): 1.0.0-beta.6 # [1.0.0-beta.6](v1.0.0-beta.5...v1.0.0-beta.6) (2023-07-27) ### Bug Fixes * stay on the same page after refreshing the browser ([4bf090f](4bf090f)) * fix: validation of the same varBinds, conditions and patterns in one profile * chore(release): 1.0.0-beta.7 # [1.0.0-beta.7](v1.0.0-beta.6...v1.0.0-beta.7) (2023-07-28) ### Bug Fixes * validation of the same varBinds, conditions and patterns in one profile ([d9bed2d](d9bed2d)) * fix: add unit tests to pipeline fix: add VALUES_DIRECTORY env variable to test-unit-backend job fix: env variable instead of .env file fix: add unit tests for frontend in the pipeline fix: fix test-unit-backend and test failing tests of frontend fix: test backend failing tests fix: working tests fix: update checkout and setup-python actions, delete actions/upload-artifact@v3 action * chore(release): 1.0.0-beta.8 # [1.0.0-beta.8](v1.0.0-beta.7...v1.0.0-beta.8) (2023-07-28) ### Bug Fixes * add unit tests to pipeline ([4ed7634](4ed7634)) * fix: add groups and single hosts in separate fields. Clear notofication when some record wasn't edited or added (#38) fix: fix broken test fix: remove unused imports fix: validate situation when user tries to add host which has the same name as a group configured in groups or reverse situation fix: allow adding host names staring with a digit fix: update get_inventory_type function and tests * chore(release): 1.0.0-beta.9 # [1.0.0-beta.9](v1.0.0-beta.8...v1.0.0-beta.9) (2023-08-02) ### Bug Fixes * add groups and single hosts in separate fields. Clear notofication when some record wasn't edited or added ([#38](#38)) ([86b4cff](86b4cff)) * fix: update test ids (#39) * chore(release): 1.0.0-beta.10 # [1.0.0-beta.10](v1.0.0-beta.9...v1.0.0-beta.10) (2023-08-07) ### Bug Fixes * update test ids ([#39](#39)) ([68d32a5](68d32a5)) * fix: upgrade varbinds validation (#40) * fix: group name can't start with a number (#41) * chore(release): 1.0.0-beta.11 # [1.0.0-beta.11](v1.0.0-beta.10...v1.0.0-beta.11) (2023-08-10) ### Bug Fixes * group name can't start with a number ([#41](#41)) ([2fc2ee6](2fc2ee6)) * upgrade varbinds validation ([#40](#40)) ([9edebff](9edebff)) * Fix/remove indices from test ids (#42) * fix: remove indices from tests ids * fix: add test ids to tables and individual cells in profiles, groups and inventory * fix: trigger release (#43) * chore(release): 1.0.0-beta.12 # [1.0.0-beta.12](v1.0.0-beta.11...v1.0.0-beta.12) (2023-08-14) ### Bug Fixes * trigger release ([#43](#43)) ([cf1967a](cf1967a)) * fix: fix bug with deleted inventory records reappearing after deleting profiles (#44) * chore(release): 1.0.0-beta.13 # [1.0.0-beta.13](v1.0.0-beta.12...v1.0.0-beta.13) (2023-09-11) ### Bug Fixes * fix bug with deleted inventory records reappearing after deleting profiles ([#44](#44)) ([599f475](599f475)) * fix: fix typos in groups (#45) * chore(release): 1.0.0-beta.14 # [1.0.0-beta.14](v1.0.0-beta.13...v1.0.0-beta.14) (2023-09-11) ### Bug Fixes * fix typos in groups ([#45](#45)) ([bad506e](bad506e)) * fix: fix apply changes api message (#46) * chore(release): 1.0.0-beta.15 # [1.0.0-beta.15](v1.0.0-beta.14...v1.0.0-beta.15) (2023-09-12) ### Bug Fixes * fix apply changes api message ([#46](#46)) ([8d72e17](8d72e17)) * fix: add max walk interval validation, fix clicking on group names, add max group name length validation (#47) * chore(release): 1.0.0-beta.16 # [1.0.0-beta.16](v1.0.0-beta.15...v1.0.0-beta.16) (2023-09-12) ### Bug Fixes * add max walk interval validation, fix clicking on group names, add max group name length validation ([#47](#47)) ([b9ad7d7](b9ad7d7)) * fix: add regex and negation options for conditional profiles (#48) fix: add unit test for conditional profile negation fix: update backend unit test * chore(release): 1.0.0-beta.17 # [1.0.0-beta.17](v1.0.0-beta.16...v1.0.0-beta.17) (2023-09-15) ### Bug Fixes * add regex and negation options for conditional profiles ([#48](#48)) ([a34ab61](a34ab61)) * fix: fix typos in ui (#49) * chore(release): 1.0.0-beta.18 # [1.0.0-beta.18](v1.0.0-beta.17...v1.0.0-beta.18) (2023-10-04) ### Bug Fixes * fix typos in ui ([#49](#49)) ([ccb482d](ccb482d)) --------- Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.