Skip to content

Commit

Permalink
fix: lint issue
Browse files Browse the repository at this point in the history
  • Loading branch information
rohanm-crest committed Jun 28, 2024
1 parent 356b2f1 commit 28b4eb5
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
1 change: 0 additions & 1 deletion tests/unit/test_app_conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ def test_update_when_should_not_be_visible():
False,
True,
supported_themes=''

)
with tempfile.TemporaryDirectory() as temp_dir:
output_app_conf_path = os.path.join(temp_dir, app_conf_lib.APP_CONF_FILE_NAME)
Expand Down
7 changes: 4 additions & 3 deletions ui/src/pages/EntryPageStyle.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,15 +40,16 @@ const defaultThemeSplunkThemeProviderMap = {
},
};

let ThemeProviderSettings = defaultThemeSplunkThemeProviderMap[defaultTheme];
let themeProviderSettings = defaultThemeSplunkThemeProviderMap[defaultTheme];
const getThemeProviderSettings = () => themeProviderSettings;

getUserTheme().then((theme) => {
const isDarkTheme = theme === 'dark';

document.body.style.backgroundColor = isDarkTheme ? '#171d21' : '#ffffff';
ThemeProviderSettings = isDarkTheme
themeProviderSettings = isDarkTheme
? defaultThemeSplunkThemeProviderMap.enterpriseDark
: defaultThemeSplunkThemeProviderMap[defaultTheme];
});

export { StyledContainer, StyledGreeting, ThemeProviderSettings, StyledButton };
export { StyledContainer, StyledGreeting, getThemeProviderSettings, StyledButton };
2 changes: 1 addition & 1 deletion ui/src/pages/entry_page.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ import React, { Suspense } from 'react';
import layout from '@splunk/react-page';
import { BrowserRouter as Router } from 'react-router-dom';
import { SplunkThemeProvider } from '@splunk/themes';
import { WaitSpinnerWrapper } from '../components/table/CustomTableStyle';
import { getUserTheme } from '@splunk/splunk-utils/themes';
import { WaitSpinnerWrapper } from '../components/table/CustomTableStyle';

import { StyledContainer, ThemeProviderSettings } from './EntryPageStyle';
import { PAGE_CONF, PAGE_DASHBOARD, PAGE_INPUT } from '../constants/pages';
Expand Down

0 comments on commit 28b4eb5

Please sign in to comment.