feat: sort table by visible text #1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtsvetkov-splunk
requested changes
May 27, 2024
vtsvetkov-splunk
previously approved these changes
May 29, 2024
|
|
||
| export const ROW_DATA = [ | ||
| { | ||
| name: 'aaaaaa', |
vtsvetkov-splunk
previously approved these changes
Jun 3, 2024
| const allCustomTextsDesc = document.querySelectorAll('[data-column="custom_text"]'); | ||
| const mappedTextDesc = Array.from(allCustomTextsDesc).map((el: Node) => el.textContent); | ||
|
|
||
| expect(mappedTextDesc).toMatchSnapshot(); |
There was a problem hiding this comment.
From my point of view, inline snapshots are more useful here. You don't have to jump to another file to see what is there, and the size is not big
vtsvetkov-splunk
approved these changes
Jun 4, 2024
artemrys
approved these changes
Jun 4, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: ADDON-59778
Summary
[UCC UI] Add support for sorting functionality when custom mapping is used in global config file
Changes
Sorting functionality works on mapped text not on keys.
User experience
Right now if user will sort by mapped property it will be displayed correctly.
Checklist
If your change doesn't seem to apply, please leave them unchecked.