Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): add resource monitoring tab and information about input status #1209

Merged
merged 10 commits into from
Jun 11, 2024

Conversation

sgoral-splunk
Copy link
Contributor

@sgoral-splunk sgoral-splunk commented May 27, 2024

Issue number:ADDON-70514

Summary

Extending monitoring dashboard page with resource monitoring and adding information about disabled inputs to the table.

Changes

  • added new definition.json for resource consumption
  • changed query for the table for "input" item in the dropdown

User experience

  • a new resource monitoring page is available
  • in the table when filtered by inputs, a column has been added informing whether the input is active or not

Checklist

If your change doesn't seem to apply, please leave them unchecked.

@sgoral-splunk sgoral-splunk changed the title Feat/resource monitoring disabled inputs feat: add resource monitoring tab and information about input status May 27, 2024
@sgoral-splunk sgoral-splunk marked this pull request as ready for review May 27, 2024 14:58
@sgoral-splunk sgoral-splunk requested review from a team as code owners May 27, 2024 14:58
@vtsvetkov-splunk
Copy link
Collaborator

the scope can be dashboard
feat(dashboard): add resource monitoring tab and information about input status

@sgoral-splunk sgoral-splunk changed the title feat: add resource monitoring tab and information about input status feat(dashboard): add resource monitoring tab and information about input status May 27, 2024
ui/src/pages/Dashboard/dashboardStyle.css Show resolved Hide resolved
ui/src/pages/Dashboard/dashboardStyle.css Outdated Show resolved Hide resolved
ui/src/pages/Dashboard/dashboardStyle.css Outdated Show resolved Hide resolved
ui/src/pages/Dashboard/dashboardStyle.css Outdated Show resolved Hide resolved
splunk_add_on_ucc_framework/dashboard.py Outdated Show resolved Hide resolved
splunk_add_on_ucc_framework/dashboard.py Outdated Show resolved Hide resolved
splunk_add_on_ucc_framework/dashboard.py Outdated Show resolved Hide resolved
Copy link
Member

@artemrys artemrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sgoral-splunk do we have Anna's approval for this PR?

@artemrys
Copy link
Member

artemrys commented Jun 9, 2024

Unit tests are failing, @sgoral-splunk cab you please take a look?

Copy link
Member

@artemrys artemrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not manage to go through very deep in reviewing, I saw the demo and it looks quite good.

@artemrys artemrys merged commit e8acfd9 into develop Jun 11, 2024
60 of 61 checks passed
@artemrys artemrys deleted the feat/resource_monitoring_disabled_inputs branch June 11, 2024 13:19
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants