ADDON-34277: Implemented filter functionality in the table component #121
Conversation
tbalar-splunk
requested review from
mchavda-splunk,
dkhatri-crest,
mamin-crest and
harshpatel-crest
|
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request |
| function TableFilter(props) { | ||
|
|
||
| return ( | ||
| <> |
There was a problem hiding this comment.
@tbalar-splunk Please remove the empty fragment since it has a single child element
There was a problem hiding this comment.
This is because we need to add some style to the filter component. (Currently, we have not added a style to this component)
What do you think should I removed now and will add later when needed?
| * @param row {Object} row | ||
| */ | ||
| const changeStatus = (row) => { | ||
| // let oldData = rowData['sfdc_event_log']; |
There was a problem hiding this comment.
@tbalar-splunk Please remove commented code.
There was a problem hiding this comment.
I have removed all the commented code. this is for reference as this is going to be implemented in the next PR
| <TableWrapper | ||
| isInput={isInput} | ||
| isInput={isInput} | ||
| isInput={isInput} |
There was a problem hiding this comment.
@tbalar-splunk Please remove duplicate props.
|
Expected release notes (by @tbalar-splunk) features: fixes: others (will not be included in Semantic-Release notes):
|
|
🎉 This PR is included in version 4.4.0-develop.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 5.0.0-develop.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
JIRA Ticket: https://jira.splunk.com/browse/ADDON-34277
Filter functionality is working in the table. For that, we have created a TableFilter component and a filter will also be performed on input type as well.
Note:
For this PR we are passing the data to the component using props only, in the upcoming PR we will be implementing React context API to pass the data to the child component.