Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(download-button): fix dynamic style component declaration #1213

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

vtsvetkov-splunk
Copy link
Collaborator

@vtsvetkov-splunk vtsvetkov-splunk commented May 29, 2024

Issue number:

Summary

styled-components throws error

OpenApiDownloadBtn.tsx:8 The component styled.div with the id of "sc-hIUJlX" has been created dynamically. You may see this warning because you've called styled inside another component. To resolve this only create new StyledComponents outside of any render method and function component.

We should not declare styled components inside a render function

Changes

  • styled components have been removed since they are not needed
  • Icon moved inside Download button

User experience

No user noticable changes

Checklist

If your change doesn't seem to apply, please leave them unchecked.

@vtsvetkov-splunk vtsvetkov-splunk requested a review from a team as a code owner May 29, 2024 12:10
@artemrys artemrys merged commit a98d442 into develop Jun 4, 2024
60 of 61 checks passed
@artemrys artemrys deleted the feature/download-component-styles branch June 4, 2024 15:24
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants