Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(custom_row): pass default row value to custom row component #1218

Merged
merged 13 commits into from
Jun 24, 2024

Conversation

rohanm-crest
Copy link
Contributor

@rohanm-crest rohanm-crest commented May 30, 2024

**Issue number: ADDON-70909

Summary

Changes

Added the new method getDLRows in the custom row component for updating the custom values.
Updated the documentation to show the user can access the row fields in the custom row component.

User experience

User can select what to display in a custom row by selecting the render method or getDLRows method.

Checklist

@rohanm-crest rohanm-crest added the documentation Improvements or additions to documentation label May 30, 2024
@rohanm-crest rohanm-crest self-assigned this May 30, 2024
@rohanm-crest rohanm-crest requested a review from a team as a code owner May 30, 2024 06:15
@artemrys
Copy link
Member

artemrys commented Jun 4, 2024

@soleksy-splunk can you please review this and merge if you are okay with the change?

@soleksy-splunk
Copy link
Contributor

@soleksy-splunk can you please review this and merge if you are okay with the change?

we can merge that one but as a part of that ticket we agreed to do other modifications as this is an improvement but still does not fix issue that was raised with me.

To solve it we agreed that method getDLRow(currentDataRow) will be added to custom class code and if it is present we pass there current data and we display result in our code base, thanks to that users only handle text modifications and we still keep the same display logic.

@rohanm-crest not sure if you want to include it inside that PR or create a fresh new one. (i'm fine with either)

@rohanm-crest rohanm-crest changed the title docs(custom_row): updated the docs for custom row component feat(custom_row): Added the getDLRows method functionality in custom row component Jun 12, 2024
@rohanm-crest rohanm-crest marked this pull request as ready for review June 12, 2024 12:56
Copy link
Contributor

@soleksy-splunk soleksy-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have a look at those comments, not something crucial but imo nice to have. obviously feel free to argue and dismiss comment

ui/src/components/table/CustomTableControl.jsx Outdated Show resolved Hide resolved
@rohanm-crest rohanm-crest requested a review from a team as a code owner June 14, 2024 10:18
@rohanm-crest rohanm-crest changed the title feat(custom_row): Added the getDLRows method functionality in custom row component feat(custom_row): Pass default row value to custom row component Jun 24, 2024
@artemrys artemrys changed the title feat(custom_row): Pass default row value to custom row component feat(custom_row): pass default row value to custom row component Jun 24, 2024
@vtsvetkov-splunk
Copy link
Collaborator

Don't forget to update the title

@rohanm-crest rohanm-crest merged commit 1fdebfa into develop Jun 24, 2024
45 of 46 checks passed
@rohanm-crest rohanm-crest deleted the ADDON-70909-custom-row branch June 24, 2024 10:22
@github-actions github-actions bot locked and limited conversation to collaborators Jun 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants