ci(workflow): add test-unit to required checks #1222
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: -
Summary
Github actions marks jobs as succeeded if it failed with
continue-on-error
. There is no other way to check if jobs were actually failed. That the reason why addingtest-unit
toall-checks
did not have any effect.Changes
Add output variable for every
continue-on-error
jobs that helps to identify failed ones duringall-checks
. You might check the result when tests are broken: https://github.com/splunk/addonfactory-ucc-generator/actions/runs/9365665879/job/25782687764#step:3:1User experience
No impact
Checklist
If your change doesn't seem to apply, please leave them unchecked.