Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(workflow): add test-unit to required checks #1222

Merged
merged 6 commits into from
Jun 4, 2024

Conversation

vtsvetkov-splunk
Copy link
Collaborator

@vtsvetkov-splunk vtsvetkov-splunk commented Jun 3, 2024

Issue number: -

Summary

Github actions marks jobs as succeeded if it failed with continue-on-error. There is no other way to check if jobs were actually failed. That the reason why adding test-unit to all-checks did not have any effect.

Changes

Add output variable for every continue-on-error jobs that helps to identify failed ones during all-checks. You might check the result when tests are broken: https://github.com/splunk/addonfactory-ucc-generator/actions/runs/9365665879/job/25782687764#step:3:1

User experience

No impact

Checklist

If your change doesn't seem to apply, please leave them unchecked.

@vtsvetkov-splunk vtsvetkov-splunk marked this pull request as ready for review June 4, 2024 15:43
@vtsvetkov-splunk vtsvetkov-splunk requested a review from a team as a code owner June 4, 2024 15:43
@artemrys artemrys merged commit 3be8d48 into develop Jun 4, 2024
60 of 61 checks passed
@artemrys artemrys deleted the feature/test-units-required branch June 4, 2024 19:17
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants