fix(oauth): set loglevel in oauth rh template to use log level set in add-on #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hetangmodi-crest
added
bug
hetangmodi-crest
requested review from
artemrys,
sgoral-splunk and
kkedziak-splunk
|
Depends on splunk/addonfactory-solutions-library-python#364 to be released. |
kkedziak-splunk
previously approved these changes
Jun 7, 2024
tests/unit/commands/rest_builder/test_global_config_builder_schema.py
Outdated
Show resolved
Hide resolved
kkedziak-splunk
approved these changes
Jun 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: ADDON-58434
Summary
Changes
The OAuth RH template is updated. It now fetches the configured log level in the add-on and writes logs as per the level set.
User experience
Using this feature, developers wouldn't have to update their OAuth RH file in their source code to get the log level set by the user in the add-on.
Checklist
If your change doesn't seem to apply, please leave them unchecked.