test: fix flaky unit tests #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`tests/data` tests are flaky due to `-n 10` in `pytest.ini`, they are trying to get contents from `globalConfig.json` which may be not in stable state. Examples: * https://github.com/splunk/addonfactory-ucc-generator/runs/2783628522 * https://github.com/splunk/addonfactory-ucc-generator/runs/2775867028
ghost
requested a review
from 
|
Expected release notes (by @arys-splunk) features: others (will not be included in Semantic-Release notes):
|
Codecov Report
@@ Coverage Diff @@
## main #222 +/- ##
==========================================
+ Coverage 55.94% 55.98% +0.03%
==========================================
Files 37 37
Lines 2506 2506
==========================================
+ Hits 1402 1403 +1
+ Misses 1104 1103 -1
Continue to review full report at Codecov.
|
harshpatel-crest
approved these changes
Jun 9, 2021
|
🎉 This PR is included in version 5.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests/datatests are flaky due to-n 10inpytest.ini, they are trying to get contents fromglobalConfig.jsonwhich may be not in stable state.Examples: