Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pip causing app inspect failures and NOTICE #224

Merged
merged 4 commits into from Jun 14, 2021
Merged

feat: pip causing app inspect failures and NOTICE #224

merged 4 commits into from Jun 14, 2021

Conversation

ryanfaircloth
Copy link
Contributor

@ryanfaircloth ryanfaircloth commented Jun 12, 2021 •
edited

This PR adds an additional corrective post-process to PIP to ensure add-ons will pass appinspect. It Also ensures NOTICE is included in the distribution.

@ryanfaircloth ryanfaircloth changed the title feat: pip causing app inspect failures feat: pip causing app inspect failures and NOTICE Jun 12, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2021 •
edited

Codecov Report

Merging #224 (25a680e) into main (9858189) will increase coverage by 0.34%.
The diff coverage is 100.00%.

❗ Current head 25a680e differs from pull request most recent head 2f77e70. Consider uploading reports for the commit 2f77e70 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #224      +/-   ##
==========================================
+ Coverage   55.98%   56.32%   +0.34%     
==========================================
  Files          37       37              
  Lines        2506     2512       +6     
==========================================
+ Hits         1403     1415      +12     
+ Misses       1103     1097       -6
Impacted Files Coverage Δ
splunk_add_on_ucc_framework/__init__.py 67.46% <100.00%> (+1.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9858189...2f77e70. Read the comment docs.

ghost
ghost suggested changes Jun 12, 2021
View reviewed changes
splunk_add_on_ucc_framework/__init__.py Outdated Show resolved Hide resolved
splunk_add_on_ucc_framework/__init__.py Show resolved Hide resolved
splunk_add_on_ucc_framework/__init__.py Show resolved Hide resolved
@ghost ghost mentioned this pull request Jun 12, 2021
Merged
@ghost
Copy link

ghost commented Jun 12, 2021

@rfaircloth-splunk I created a PR #225 specifically to drop support for py2/py3 libraries.

feat: Improve pip packaging
9b0c494 
Address several issues with vendoring python deps caused by newer versions of pip
* Ensure pip bootstrap components are not included in the package
* Remove dual py2/py3 suport
* Ensure no lib object has +x
rfaircloth-splunk added 2 commits June 12, 2021 18:31
@ryanfaircloth ryanfaircloth requested a review from a user June 12, 2021 22:36
@github-actions
Copy link

Expected release notes (by @rfaircloth-splunk)

features:
Improve pip packaging (9b0c494)

others (will not be included in Semantic-Release notes):
bump reuse from 0.12.1 to 0.13.0 (#228) (6256d6b)
specify output file for snyk check (#230) (d5c5442)
fix CLA assistant version (#226) (a4385a5)
resolve hadolint issues (4d65b4b)
2f77e70 Correct order of try/for
dbec08a fixup

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@ryanfaircloth ryanfaircloth merged commit d83b687 into main Jun 14, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2021
@ryanfaircloth
Copy link
Contributor Author

🎉 This PR is included in version 5.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost ghost deleted the ship-notice branch July 16, 2021 21:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@siddharth-khatsuriya siddharth-khatsuriya Awaiting requested review from siddharth-khatsuriya

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ryanfaircloth @codecov-commenter