Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate mako to jinja2 for alert actions html #293

Merged
5 commits merged into from Jul 27, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jul 26, 2021

No description provided.

@ghost ghost changed the title Refactor/migrate mako to jinja2 for alert actions html refactor: migrate mako to jinja2 for alert actions html Jul 26, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2021

Codecov Report

Merging #293 (b13fc7d) into main (6fd1374) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #293      +/-   ##
==========================================
- Coverage   75.40%   75.27%   -0.13%     
==========================================
  Files          28       28              
  Lines        1931     1921      -10     
==========================================
- Hits         1456     1446      -10     
  Misses        475      475              
Impacted Files Coverage Δ
...alert_builder/build_core/alert_actions_html_gen.py 91.17% <100.00%> (-1.14%) ⬇️
...alert_builder/build_core/alert_actions_template.py 91.66% <0.00%> (-8.34%) ⬇️
...ework/modular_alert_builder/build_core/__init__.py 91.01% <0.00%> (+1.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fd1374...b13fc7d. Read the comment docs.

@ghost ghost marked this pull request as ready for review July 26, 2021 16:35
@ghost ghost force-pushed the refactor/migrate-mako-to-jinja2-for-alert-actions-html branch from 7d2cc5c to 6085bd5 Compare July 27, 2021 06:53
@ghost ghost merged commit c7078ef into main Jul 27, 2021
@ghost ghost deleted the refactor/migrate-mako-to-jinja2-for-alert-actions-html branch July 27, 2021 12:35
@github-actions github-actions bot locked and limited conversation to collaborators Jul 27, 2021
@ryanfaircloth
Copy link
Contributor

🎉 This PR is included in version 5.5.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants