Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(install): remove downloaded package after unarchive #134

Merged
merged 2 commits into from
Nov 16, 2022

Conversation

zyphermonkey
Copy link
Contributor

package is no longer needed after unarchive and can safely be removed to keep the disk clean

package is no longer needed after unarchive and can safely be removed
to keep the disk clean
@dtwersky
Copy link
Collaborator

dtwersky commented Oct 7, 2022

@zyphermonkey The reason we decided to not remove the package is because if you run it against multiple instances, it will need to download the package many times. It annoys me sometime too to have to clean up old downloaded versions etc.

Do you have any other ideas how to clean it up without having to download it multiple times? Maybe a conditional var for that task when something like cleanup: true is passed at run-time? Maybe a tag?

@zyphermonkey
Copy link
Contributor Author

@zyphermonkey The reason we decided to not remove the package is because if you run it against multiple instances, it will need to download the package many times. It annoys me sometime too to have to clean up old downloaded versions etc.

That makes sense. I forgot in my local version we don't use delegate_to: localhost anymore so the download and cleanup is always on a per host basis.

Maybe I'll working on getting another PR put in that allows for the user to chose local vs remote. Which would also close #48.
If download location is set to remote then we'll cleanup everytime. If not leave the download on the localhost for other hosts to prevent constant re-downloads.

add var and update tasks/docs to allow for package download to be done
via ansible host or remote host

related splunk#48
@zyphermonkey
Copy link
Contributor Author

New commit adds the discussed feature although it doesn't completely close #48. I have not used the configure_apps.yml download feature yet so I need some more time to review those tasks and determine the best way to implement local vs remote downloading.

Should be good to merge with just these changes now though. 😃

@dtwersky dtwersky requested a review from jewnix October 9, 2022 16:49
@dtwersky dtwersky added the enhancement New feature or request label Oct 9, 2022
@dtwersky dtwersky self-assigned this Oct 9, 2022
@zyphermonkey
Copy link
Contributor Author

Anything I need to do for merge?

@dtwersky dtwersky merged commit a250642 into splunk:master Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants