Fixes splunk/ansible-role-for-splunk#109

[jewnix]

Switch to using the lineinfile module instead of a template. This will add the setfacl command to where is belongs instead of in a separate script, which is prone to break.

[midnight5ky]

Just curious, will this insert the line specified each time this task is ran? Wasn't sure if it'll produce duplicates of the line since it just inserts the line before ' endscript'

[jewnix]

Just curious, will this insert the line specified each time this task is ran? Wasn't sure if it'll produce duplicates of the line since it just inserts the line before ' endscript'

In my testing, it has not put it in twice

[zyphermonkey]

@jewnix
Would it be possible to revert this change?

1. I don't fully understand why this change was made.
   From the issue it seems like some were having issues with their line endings which was most likely cause by their .gitconfig settings and not the template.
2. It's not best practice (nor am I a fan of) modifying default system config files.
   Especially in the case of logrotate where it specifically gives us a .d directory to make our customization.
3. Modifying default system config files can lead to inconsistent results.
   Because we have no control over how updates might change this logrotate.d/syslog file it's quite possible a system update will completely reset it destroying the changes made in this merge.
4. This merge isn't backwards compatible with previous version of the role.
   This doesn't cleanup the previous logrotate.d/splunk_facl file causing duplicate configs for existing systems.

[jewnix]

@zyphermonkey

1. I don't fully understand why this change was made.
   From the issue it seems like some were having issues with their line endings which was most likely cause by their .gitconfig settings and not the template.

This was to fix #109 that failed because it did not have the log file directive in the script.

2. It's not best practice (nor am I a fan of) modifying default system config files.
   Especially in the case of logrotate where it specifically gives us a .d directory to make our customization.

I usually refrain from modifying system files, however I did not find a way to solve this issue without this. Any recommendations would be appreciated.

3. Modifying default system config files can lead to inconsistent results.
   Because we have no control over how updates might change this logrotate.d/syslog file it's quite possible a system update will completely reset it destroying the changes made in this merge.

I was not able to figure out a working solution. Adding /var/log in the old config file didn;t solve the issue, because no files were rotated, so the postscript did nothing.

4. This merge isn't backwards compatible with previous version of the role.
   This doesn't cleanup the previous logrotate.d/splunk_facl file causing duplicate configs for existing systems.

Good point. Removing that file should be added