Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Splunk additions #161

Merged
merged 7 commits into from
Feb 3, 2023
Merged

Remove Splunk additions #161

merged 7 commits into from
Feb 3, 2023

Conversation

arcsector
Copy link
Contributor

Adding some removals to remove_splunk.yml for better cleanup:

  • User and Group
  • THP/Ulimit files & services
  • Dmesg files
  • Firewall files and entries
  • FACL files and lineinfile's

- User/Group
- THP/Ulimit
- Dmesg
- firewall
- facl
@arcsector
Copy link
Contributor Author

Wanted to note that I was going to include the removal of the polkits from 41b2a8e, however we have to reload dbus to do that, and in my tests it's very precarious reloading dbus, sometimes resulting in a kernel panic from crashing dbus, and so I left it out until someone more experienced with that can take that on.

@jewnix
Copy link
Collaborator

jewnix commented Dec 15, 2022

I actually have a local branch to remove the user and group for a while 😄 , I just didn't push it

@dtwersky
Copy link
Collaborator

Wanted to note that I was going to include the removal of the polkits from 41b2a8e, however we have to reload dbus to do that, and in my tests it's very precarious reloading dbus, sometimes resulting in a kernel panic from crashing dbus, and so I left it out until someone more experienced with that can take that on.

when you run disable boot-start it should remove the polkit as well. At least that's the expected behavior.

@arcsector
Copy link
Contributor Author

arcsector commented Jan 5, 2023

@jewnix in some of my tests on RHEL procps doesn't exist as a service - is this the same for you? Should we add a conditional for debian machines only?

@jewnix
Copy link
Collaborator

jewnix commented Jan 11, 2023

@jewnix in some of my tests on RHEL procps doesn't exist as a service - is this the same for you? Should we add a conditional for debian machines only?

@arcsector you would be correct. I have not seen procps on RHEL based systems. In general, I've only seen dmesg disabled on Debian based systems, but it would be a good idea to add a conditional for ansible_os_family on at least the restart of this service, if not on the whole task.

@arcsector
Copy link
Contributor Author

it would be a good idea to add a conditional for ansible_os_family on at least the restart of this service, if not on the whole task.

Gotcha. Separate PR for sure.

@dtwersky dtwersky merged commit 5eb35a0 into splunk:master Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants