Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend configure license task #182

Merged
merged 2 commits into from
Apr 25, 2023

Conversation

schneewe
Copy link
Contributor

In this PR are some changes:

  1. change yes boolean to true, because of yamllint rule
  2. Adjust the step of remove the manager_uri setting when using local license. With a specific condition, e.g. upgrading to a 9.x version and want to use the newer "manager_uri" and changing to local license. It will never remove the old master_uri setting, because of the mode_option set to manager_uri. So I think it's better to have both variants in the removing step.
  3. Include the check, if the general_key changed, so we have no "changed" task like in configure_deploymentclient.conf

@dtwersky
Copy link
Collaborator

@schneewe

  1. Include the check, if the general_key changed, so we have no "changed" task like in configure_deploymentclient.conf

There is actually a PR open for this that I was about to merge, but yours includes more things, so I will cancel that one. The only thing in that PR is the addition of some documentation in README.md. If you add that to this PR, I will merge it.

@dtwersky dtwersky self-requested a review April 24, 2023 13:12
@schneewe
Copy link
Contributor Author

@dtwersky
Thanks for the hint, didn't look up before.
Added the README.md changes to this PR

@dtwersky dtwersky added the enhancement New feature or request label Apr 25, 2023
@dtwersky dtwersky merged commit 393eb51 into splunk:master Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants