Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move --npm-path option under installer script #1321

Merged
merged 3 commits into from
May 7, 2024
Merged

Move --npm-path option under installer script #1321

merged 3 commits into from
May 7, 2024

Conversation

jeffreyc-splunk
Copy link
Contributor

@jeffreyc-splunk jeffreyc-splunk commented May 3, 2024 •
edited
Loading

Requirements

  • Content follows Splunk guidelines for style and formatting.
  • You are contributing original content.

Describe the change

  • The --npm-path option is only applicable for the installer script.
  • Include "Ansible" for Node.js

@jeffreyc-splunk jeffreyc-splunk marked this pull request as ready for review May 3, 2024 15:58
@jeffreyc-splunk jeffreyc-splunk requested a review from a team as a code owner May 3, 2024 15:58
@mfoulds-splunk mfoulds-splunk added the stop-alert Stops Slack notification in #o11y-docs-feedback so that PR can be worked wo unnecessary noise label May 3, 2024
@theletterf theletterf merged commit c4b1676 into splunk:main May 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theletterf theletterf theletterf approved these changes

@aurbiztondo-splunk aurbiztondo-splunk aurbiztondo-splunk approved these changes

Assignees
No one assigned
Labels
external stop-alert Stops Slack notification in #o11y-docs-feedback so that PR can be worked wo unnecessary noise
Projects
None yet
Milestone
No milestone
5 participants
@jeffreyc-splunk @theletterf @aurbiztondo-splunk @mfoulds-splunk @srv-rpa-o11y-docs-splunk