Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cis20 and nist tag checking #2390

Merged
merged 50 commits into from
Nov 15, 2022
Merged

Conversation

pyth0n1c
Copy link
Collaborator

Enhance validation for detection tags.
Improved validation for CIS20 tags
Added NIST tag validation

nist category.  Updated the regex used
to check CIS20 numbers so that it does
not allow invalid numbers/lines to
pass validation and provided a more
verbose error message.
@pyth0n1c pyth0n1c added the WIP DO NOT MERGE Work in Progress label Sep 28, 2022
@auto-assign auto-assign bot requested a review from P4T12ICK September 28, 2022 19:52
@josehelps josehelps removed the WIP DO NOT MERGE Work in Progress label Nov 15, 2022
@josehelps josehelps requested review from josehelps and removed request for P4T12ICK November 15, 2022 20:01
Copy link
Collaborator

@josehelps josehelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josehelps josehelps merged commit f219916 into develop Nov 15, 2022
@delete-merged-branch delete-merged-branch bot deleted the add_cis20_and_nist_tag_checking branch November 15, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants