Fixes for contentctl migration #2881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on the following playbooks. the first had an invalid uuid (improper number of characters). The second had unallowed characters in the name (underscores). I will reach out to the devs for this content to understand what implications these changes may have.
… named referenced detections. Check with Playbook SME to understand the full implications of these changes.
ljstella
approved these changes
Oct 9, 2023
Based on this review, I have dropped the WIP / Work In Progress Tag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of issues were caught by the new contentctl codebase.
While fixes were made that "resolve" these errors, we should ensure that these were actually errors and do not introduce regressions into the playbooks.