Wget/Curl Download and Bash Execution: Changing logic for search terms, to make searches comply with title and intention #2997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DipsyTipsy
changed the title
patel-bhavin
requested review from
MHaggis
and removed request for
patel-bhavin and
P4T12ICK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
The logic in the queries here has an OR between the matching on quiet/stdout and the match for pipe and "bash".
This causes the query to hit when wget/curl is either silenced or piped to bash.
From the title i would maybe assume that an AND between the quiet/stdout check and pipe+bash check would be the correct queries?
Searches modified:
Checklist
<platform>_<mitre att&ck technique>_<short description>nomenclature