ci: fixing docker auth for pushing images on release

splunk · Mar 7, 2020 · f8e3f3d · f8e3f3d
1 parent 9cf26dd
commit f8e3f3d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -90,6 +90,7 @@ jobs:
               run: |
                   yarn install --frozen-lockfile
                   yarn semantic-release
+                  docker login docker.pkg.github.com -u $GITHUB_ACTOR -p $GITHUB_TOKEN
                   yarn ts-node scripts/postrelease.ts
               env:
                   GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

diff --git a/scripts/postrelease.ts b/scripts/postrelease.ts
@@ -89,9 +89,13 @@ export async function main(args: string[]) {
     if (process.env.DOCKER_HUB_TOKEN) {
         console.log('Logging in to docker hub');
         await execa('docker', ['login', '-u', 'dltbuilder', '-p', process.env.DOCKER_HUB_TOKEN]);
+    }
+    let publishedToDockerhub = false;
+    try {
         await publishImageVersions(DOCKER_HUB_IMAGE);
-    } else {
-        console.log('No docker hub token set. Skipping publish to docker hub.');
+        publishedToDockerhub = true;
+    } catch (e) {
+        console.log('Failed to push image to docker hub:', e.message);
     }
 
     const bullet = (prefix: string, title: string, href: string) => `- ${prefix}: [${title}](${href})`;
@@ -112,7 +116,7 @@ export async function main(args: string[]) {
                 semver.version
             )}`
         ),
-        process.env.DOCKER_HUB_TOKEN != null
+        publishedToDockerhub
             ? bullet(
                   'Docker image on docker hub',
                   `${DOCKER_HUB_IMAGE}:${semver.version}`,