Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Geth-specific metrics not collected #49

Closed
j4ys0n opened this issue Jun 10, 2020 · 3 comments · Fixed by #59
Closed

Geth-specific metrics not collected #49

j4ys0n opened this issue Jun 10, 2020 · 3 comments · Fixed by #59
Assignees
@ziegfried
Labels
bug Something isn't working released

Comments

@j4ys0n
Copy link
Contributor

j4ys0n commented Jun 10, 2020 •
edited

When connected to a geth or quorum node ethlogger continually reports the following error:

2020-06-10T21:34:23.624Z ethlogger:nodestats:error Failed to collect node metrics (35 consecutive failures): JsonRpcError: the method debug_metrics does not exist/is not available
    at Object.checkError (/ethlogger/lib/eth/jsonrpc.js:31:15)
    at Object.callback (/ethlogger/lib/eth/client.js:114:35)
    at executeBatchRequest (/ethlogger/lib/eth/client.js:24:23)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async Timeout.BatchedEthereumClient.processQueue (/ethlogger/lib/eth/client.js:97:20) {
  code: -32601,
  data: undefined
}

geth docs: https://geth.ethereum.org/docs/rpc/ns-debug
@atoulme
Copy link
Contributor

atoulme commented Jun 10, 2020

I found the commit where this was removed: ethereum/go-ethereum@29bc982#diff-3e693b632c1db48405aabd1a0715483b

@ziegfried ziegfried changed the title debug_metrics rpc method seems to have been removed from geth Geth-specific metrics not collected Jun 10, 2020
@ziegfried ziegfried added the bug Something isn't working label Jun 10, 2020
@j4ys0n
Copy link
Contributor Author

j4ys0n commented Jun 12, 2020

Looks like this applies to geth 1.9.0+ and quorum 2.6+

@ziegfried ziegfried self-assigned this Aug 7, 2020
ziegfried added a commit that referenced this issue Aug 7, 2020
@ziegfried
fix: 🐛 stop polling debug_metrics for recent Geth versions
66180f7 
Added new check whether geth supports the debug_metrics RPC method,
since support has been dropped in newer versions (as of 1.9). This fixes
the issue where ethlogger output is spammed with error messages of the
node metrics request failing.

✅ Closes: #49
@ziegfried ziegfried mentioned this issue Aug 7, 2020
Merged
github-actions bot pushed a commit that referenced this issue Aug 7, 2020
@semantic-release-bot
chore(release): 2.1.1
cb5f740 
## [2.1.1](v2.1.0...v2.1.1) (2020-08-07)

### Bug Fixes

* 🐛 stop polling debug_metrics for recent Geth versions ([66180f7](66180f7)), closes [#49](#49)
@github-actions
Copy link

github-actions bot commented Aug 7, 2020

🎉 This issue has been resolved in version 2.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ziegfried ziegfried

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for geth node metrics errors in ethlogger output splunk/splunk-connect-for-ethereum
3 participants
@atoulme @ziegfried @j4ys0n