Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for configuring namespaces #790

Conversation

FalconerTC
Copy link
Contributor

@FalconerTC FalconerTC commented Jul 18, 2022

Proposed changes

Currently, almost all resources being supplied by these charts are defaulting to .Release.Namespace. This is generally fine, but it's not configurable, and it doesn't support Gitops because helm template does not add .Release.Namespace for manifests (helm/helm#3553). The result is that if you try to create the manifests and then apply them without using helm install, everything will be put in the default namespace

This makes Namespace explicit on all relevant resources.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I have read the CLA
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@hvaghani221
Copy link
Contributor

@FalconerTC can you fix failed tests?

@FalconerTC
Copy link
Contributor Author

@harshit-splunk I can't seem to get the e2e tests to work. Any advice here?

@FalconerTC FalconerTC force-pushed the falconertc/support_configured_namespace branch 2 times, most recently from 7e0669b to 911a620 Compare July 29, 2022 13:31
@FalconerTC FalconerTC force-pushed the falconertc/support_configured_namespace branch from 911a620 to f34499e Compare July 29, 2022 16:18
Copy link
Contributor

@hvaghani221 hvaghani221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hvaghani221 hvaghani221 merged commit c849d06 into splunk:develop Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants