feat: adapt unit tests

splunk · Aug 18, 2021 · 7071f33 · 7071f33
1 parent 3b40ca9
commit 7071f33
Showing 1 changed file with 4 additions and 8 deletions.
diff --git a/tests/test_translator.py b/tests/test_translator.py
@@ -198,8 +198,7 @@ def test_format_metric(self):
             "val": "123",
             "val_type": "TimeTicks",
         }
-        translated_metrics = self.my_translator.format_metric_data(input_var_binds)
-        translated_dict = json.loads(translated_metrics)
+        translated_dict = self.my_translator.format_metric_data(input_var_binds)
         for required_key in ["metric_name", "_value", "metric_type"]:
             assert required_key in translated_dict
         assert translated_dict["metric_name"] == "sc4snmp.SNMPv2-MIB.sysUpTime_0"
@@ -213,8 +212,7 @@ def test_format_non_existing_metric(self):
             "val": "123",
             "val_type": "TimeTicks",
         }
-        translated_metrics = self.my_translator.format_metric_data(input_var_binds)
-        translated_dict = json.loads(translated_metrics)
+        translated_dict = self.my_translator.format_metric_data(input_var_binds)
         for required_key in ["metric_name", "_value", "metric_type"]:
             assert required_key in translated_dict
         assert translated_dict["_value"] == input_var_binds["val"]
@@ -287,8 +285,7 @@ def test_translate_all_snmp_simulator_data_types(self):
             translated_metrics = self.my_translator.format_metric_data(
                 input_var_binds_colons
             )
-            json_metrics = json.loads(translated_metrics)
-            assert json_metrics["metric_name"] == expected_translations[index]
+            assert translated_metrics["metric_name"] == expected_translations[index]
 
     @mongomock.patch()
     def test_more_mib_files(self):
@@ -310,8 +307,7 @@ def test_more_mib_files(self):
         ]
 
         for i in range(0, len(input_var_binds)):
-            translated_metrics = self.my_translator.format_metric_data(
+            translated_dict = self.my_translator.format_metric_data(
                 input_var_binds[i]
             )
-            translated_dict = json.loads(translated_metrics)
             assert translated_dict["metric_name"] == expected_values[i]