Skip to content
This repository has been archived by the owner on Dec 17, 2021. It is now read-only.

Feature/redo walk #95

Merged
merged 13 commits into from
Jul 21, 2021
Merged

Feature/redo walk #95

merged 13 commits into from
Jul 21, 2021

Conversation

lstoppa
Copy link
Contributor

@lstoppa lstoppa commented Jul 20, 2021

No description provided.

- added some code for handling sysUpTimeInstance and a general
  function that should decide -based on some SNMP data- when a walk
  should be executed.
- added a new task that will potentially redo a SNMPWALK based on sysUpTimeInstance
- general refactoring (Poller)
- fixed some issues with mongo when retrieving REAL-TIME-DATA-COLLECTION
- added a way to get 1.3.6.1.2.1.1.3.0 before checking whether a WALK is needed
- created a named method for creating scheduler map keys
  (create_poller_scheduler_entry_key)
- scheduler was set to one second (fixed that)
@github-actions
Copy link
Contributor

github-actions bot commented Jul 20, 2021

CLA Assistant Lite bot CLA Assistant Lite bot All contributors have signed the COC ✍️ ✅

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 177 files.

Valid Invalid Ignored Fixed
29 1 147 0
Click to see the invalid file list
  • tests/test_real_time_data.py

tests/test_real_time_data.py Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2021

Codecov Report

Merging #95 (1e81748) into develop (d5879c5) will increase coverage by 1.14%.
The diff coverage is 27.15%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #95      +/-   ##
===========================================
+ Coverage    31.91%   33.06%   +1.14%     
===========================================
  Files           15       19       +4     
  Lines          633      735     +102     
===========================================
+ Hits           202      243      +41     
- Misses         431      492      +61     
Impacted Files Coverage Δ
splunk_connect_for_snmp_poller/manager/poller.py 0.00% <0.00%> (ø)
...onnect_for_snmp_poller/manager/poller_utilities.py 0.00% <0.00%> (ø)
splunk_connect_for_snmp_poller/mongo.py 0.00% <0.00%> (ø)
splunk_connect_for_snmp_poller/utilities.py 28.88% <0.00%> (-0.66%) ⬇️
...for_snmp_poller/manager/realtime/real_time_data.py 88.46% <88.46%> (ø)
...t_for_snmp_poller/manager/realtime/oid_constant.py 100.00% <100.00%> (ø)
tests/test_real_time_data.py 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5879c5...1e81748. Read the comment docs.

@lstoppa lstoppa changed the base branch from main to develop July 20, 2021 07:20
@lstoppa lstoppa requested a review from lingy1028 July 20, 2021 15:52
@lstoppa
Copy link
Contributor Author

lstoppa commented Jul 21, 2021

I have read the Code of Conduct and I hereby accept the Terms

- again lint was complaining about non-sorted imports
- we were calling int(frequency) even if frequency was already an int.
@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2021

Expected release notes (by @lstoppa)

features:
ADDON-37033 (refactoring) - scheduler was set to one second (fixed that) (388d2b8)
ADDON-37033 (refactoring) - created a named method for creating scheduler map keys (create_poller_scheduler_entry_key) (c375920)
ADDON-37033 (add sync SNMPGET) - added a way to get 1.3.6.1.2.1.1.3.0 before checking whether a WALK is needed (48c8251)
ADDON-37033 (add real-time task that handles SNMP WALK) - added a new task that will potentially redo a SNMPWALK based on sysUpTimeInstance - general refactoring (Poller) - fixed some issues with mongo when retrieving REAL-TIME-DATA-COLLECTION (31bc71e)
ADDON-37033 (add support for mongodb real-time data storage) (fbf41cd)
ADDON-37033 (add sysUpTimeInstance initial support) - added some code for handling sysUpTimeInstance and a general function that should decide -based on some SNMP data- when a walk should be executed. (ba69e3b)
support polling the same IP address using multiple profiles (#92) (a6320ca)

others (will not be included in Semantic-Release notes):
ADDON-37033 (code-review #3) - we were calling int(frequency) even if frequency was already an int. (1e81748)
ADDON-37033 (code-review #2) - again lint was complaining about non-sorted imports (3318040)
ADDON-37033 (code-review #1) (6e76fe9)
ADDON-37033 (sanitizers #4) (375897b)
ADDON-37033 (sanitizers #3) (039f89b)
ADDON-37033 (sanitizers #2) (45d5734)
ADDON-37033 (sanitizers #1) (0a494e3)
d5879c5 Stubs for lint
9cff184 Stubs for lint
adddbea Stubs for lint
5dc1549 Stubs for lint
2c5a5c3 Feat/multiple profiles2 (#93)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@lstoppa lstoppa merged commit ebe3ebf into develop Jul 21, 2021
@lstoppa lstoppa deleted the feature/redo-walk branch July 21, 2021 13:08
@github-actions github-actions bot locked and limited conversation to collaborators Jul 21, 2021
@ryanfaircloth
Copy link
Contributor

🎉 This PR is included in version 1.5.0-develop.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants