Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #183 - okHttpClient timeout settings #199

Merged

Conversation

steyng
Copy link
Contributor

@steyng steyng commented Sep 11, 2021

This is the proposed fix for #183 where the timeout settings do not appear to get used for the http client configuration.

@stokpop
Copy link
Contributor

stokpop commented Oct 5, 2021

This pull request seems to fix the same "timeouts not used" issue as this pull request: #178

Can these pull request be merged?

…and update the default timeout settings to reasonable defaults as suggested by @stokpop.
@steyng
Copy link
Contributor Author

steyng commented Oct 12, 2021

I had missed pull request #178. Have aligned this with #178 and added in some of the default timeouts suggested by @stokpop - set timeouts similar to okHttpClient, i.e.

        public static final long DEFAULT_CONNECT_TIMEOUT = 3000;
        public static final long DEFAULT_WRITE_TIMEOUT = 10000; // 0 means no timeout
        public static final long DEFAULT_CALL_TIMEOUT = 0;
        public static final long DEFAULT_READ_TIMEOUT = 10000;

@vmalaviya-splunk vmalaviya-splunk merged commit f4c5d7d into splunk:main Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants