Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose flush() method on Logback and Log4j appenders to flush underlying HttpEventCollectorSender and OkHttpClient #207

Merged

Conversation

stevejagodzinski
Copy link

@stevejagodzinski stevejagodzinski commented Oct 22, 2021

Build upon the previous partial solution to #152

Instead of stopping the appender at then end of a lambda function, just call flush() on the appender.

This way the appender can be re-used next time the lambda function is invoked.

The underlying httpClient is flushed (up to the configured timeout).

@stevejagodzinski stevejagodzinski changed the title Expose flush() method on Logback and Log4j appenders. Expose flush() method on Logback and Log4j appenders to flush underlying HttpEventCollectorSender and OkHttpClient Oct 23, 2021
@stevejagodzinski
Copy link
Author

The failing checks seem un-related to the changes in this MR. Perhaps the CI pipeline is unstable?

#210 aims to debug this pipeline failure.

@vmalaviya-splunk vmalaviya-splunk merged commit cd9bf61 into splunk:main Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants