Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Raw Endpoint support to HEC #75

Merged
merged 3 commits into from
Jun 1, 2018
Merged

Added Raw Endpoint support to HEC #75

merged 3 commits into from
Jun 1, 2018

Conversation

dan1
Copy link
Contributor

@dan1 dan1 commented May 29, 2018

Ported change from #58

@dan1 dan1 mentioned this pull request May 29, 2018
Closed
@dan1
Clean up getter setters for new properties.
51e7799 
HttpEventCollectorLogbackAppender

- channel
- type
zenmoto
zenmoto approved these changes May 30, 2018
View reviewed changes
Copy link
Contributor

@zenmoto zenmoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a spot where we can add documentation and/or tests?

@dan1
Added check for empty string along with null for channel
9af6a32 
- Also added comments for channel and type
@tdhellmann tdhellmann mentioned this pull request Jun 1, 2018
Closed
@dan1 dan1 merged commit ccd8547 into develop Jun 1, 2018
@shakeelmohamed shakeelmohamed deleted the HEC-raw branch June 4, 2018 17:31
@tdhellmann tdhellmann mentioned this pull request Aug 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zenmoto zenmoto zenmoto approved these changes

@shakeelmohamed shakeelmohamed shakeelmohamed approved these changes

Assignees

@shakeelmohamed shakeelmohamed

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dan1 @zenmoto @shakeelmohamed