Event body serializer #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ljiang1
commented
Oct 24, 2018
ljiang1
commented
- port over izrobin's work Add support for custom event body serializer #83
- make fixes to some code issue to make sure it compliant with our expected message format
- add a test for using user-defined EventBodySerializer
- some minor format/typo fix in tests
Customizable & pluggable event serializer support for the HttpEventCollectorAdapter.
…splunk and make sure tests passing; fix some typo
…er-defined eventBodySerializer
shakeelmohamed
approved these changes
Oct 24, 2018
shakeelmohamed
suggested changes
Oct 24, 2018
There was a problem hiding this comment.
There are some compilation errors, please fix them @ljiang1
…ary-javalogging into event-body-serializer
shakeelmohamed
approved these changes
Oct 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.