Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Operator SDK to v0.18.2 #312

Merged
merged 3 commits into from
May 5, 2021
Merged

Upgrade Operator SDK to v0.18.2 #312

merged 3 commits into from
May 5, 2021

Conversation

vebken-splunk
Copy link
Contributor

No description provided.

@vebken-splunk vebken-splunk force-pushed the bugfix/CSPL-612 branch 2 times, most recently from f9913e0 to af30793 Compare April 9, 2021 22:49
@vebken-splunk vebken-splunk changed the title operator sdk upgrade test (do not merge) Upgrade Operator SDK to v0.18.2 Apr 15, 2021
jryb
jryb reviewed Apr 26, 2021
View reviewed changes
build/make_bundle.sh Show resolved Hide resolved
build/Dockerfile.builder Show resolved Hide resolved
sgontla
sgontla reviewed Apr 26, 2021
View reviewed changes
Copy link
Collaborator

@sgontla sgontla left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like all the changes on CRD files are due to the yq version. Wondering if you are using the yq version 3.3.x, by any chance? yq 3.3.x output is not uniform across the Linux distributions, so we stuck with 3.2.x.

@vebken-splunk
Copy link
Contributor Author

@gaurav-splunk @sgontla @jryb @akondur just a note, these changes are in flux right now as a result of trying to handle the issues described here #312 (comment)

We are seeing issues due to the interaction of OperatorSDK v0.18.2 and the current iteration of the make_bundle.sh script.

Working through those, so perhaps reviewing should be put on hold for now.

@vebken-splunk vebken-splunk reopened this Apr 26, 2021
@vebken-splunk
Copy link
Contributor Author

Seems like all the changes on CRD files are due to the yq version. Wondering if you are using the yq version 3.3.x, by any chance? yq 3.3.x output is not uniform across the Linux distributions, so we stuck with 3.2.x.

Regarding your comment @sgontla the CRD changes occur with yq v3.2.1, they are due to running

operator-sdk generate crds

with Operator SDK version 0.18.2.

@smohan-splunk smohan-splunk merged commit 8fffe9f into develop May 5, 2021
@pogdin pogdin mentioned this pull request Jun 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaurav-splunk gaurav-splunk gaurav-splunk left review comments

@akondur akondur akondur approved these changes

@jryb jryb jryb approved these changes

@sgontla sgontla sgontla approved these changes

@pdhanoya-splunk pdhanoya-splunk Awaiting requested review from pdhanoya-splunk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vebken-splunk @jryb @gaurav-splunk @akondur @sgontla @smohan-splunk