Rename and cleanup follow-up for chunk synchronization #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amysutedja
force-pushed
the
chunk-synchronization-cleanup
branch
from
9c3c9bc
to
e740168
Compare
shilpabijam
reviewed
Jun 8, 2020
shilpabijam
approved these changes
Jun 10, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes:
_record_counttopending_record_countand_total_record_counttocommitted_record_count. The old properties are still callable but produce a deprecated warning. (If you were actually setting those values, you probably shouldn't have been doing that.)RecordWriterV1now updatescommitted_record_countbefore clearing records. Previously it was the other way around, which seems like it would always produce incorrect data.