Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default kvstore owner to nobody #413

Merged
merged 6 commits into from Nov 10, 2021
Merged

Conversation

ashah-splunk
Copy link
Contributor

Added a new property for the kvstore owner, which is set to "nobody" by default. But a setter is added for future purpose when the owner value is required to be changed

default value for owner set to "nobody"
commenting the need to set kvstore owner to default value of  "nobody" as new property is created for the kvstore owner with default to "nobody"
Copy link
Contributor

@fantavlik fantavlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for updating testcases for both the default case (nobody) and override case (admin) 🚀

@ashah-splunk ashah-splunk merged commit 4a1d31a into develop Nov 10, 2021
@vmalaviya-splunk vmalaviya-splunk mentioned this pull request Nov 11, 2021
@ashah-splunk ashah-splunk deleted the default-kvstore-owner-nobody branch December 8, 2021 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants