-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support of multi accounts files #10 #64
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look mostly fine, thanks for contributing. There's just some cleanup to do and I think the date-format-guessing needs to be removed
|
||
const US_DATE_FORMATS = ['MM-DD-YYYYHH:mm:ss', 'MM-DD-YYYY', 'MM-DD-YY']; | ||
const UK_DATE_FORMATS = ['DD-MM-YYYYHH:mm:ss', 'DD-MM-YYYY', 'DD-MM-YY']; | ||
|
||
function parseDate(dateStr, formats) { | ||
if (formats === 'us') { | ||
if (formats === 'us' || dateStr.includes("'")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems a bit risky to say that any dateStr
that includes a '
is a US date format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any better proposition? This code do not breaks compatibility but is open also for other date format, that I am using.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per #26 you can pass in a dateFormat
option to control how the dates are parsed. us
is only supported for backward compatibility
Bumps [eslint-plugin-import](https://github.com/benmosher/eslint-plugin-import) from 2.20.1 to 2.22.1. - [Release notes](https://github.com/benmosher/eslint-plugin-import/releases) - [Changelog](https://github.com/benmosher/eslint-plugin-import/blob/master/CHANGELOG.md) - [Commits](import-js/eslint-plugin-import@v2.20.1...v2.22.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
…lint-plugin-import-2.22.1
# Conflicts: # lib/qif2json.js # test/accounts.tests.js
In this pull request packages are updated:
Support for multi accounts files was added.
Support for single account files was not changed.
Structure of single account json:
Structure of multi account json: