feat(rename): pass file to rename as a first arguments when it's a fu…

…nction This is a break change when using rename
spmjs · May 5, 2015 · 977000a · 977000a
1 parent 48fe2d0
commit 977000a
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 8 deletions.
diff --git a/lib/transport.js b/lib/transport.js
@@ -95,7 +95,7 @@ function getStream(opt) {
     '.css': css(opt),
     '.css.js': pipe(
       // overide rename for this
-      css(extend({}, opt, {rename: rename, cssjs:true})),
+      css(extend({}, opt, {rename: {}, cssjs:true})),
       css2js(opt)
     ),
     '.json': json(opt),
@@ -120,10 +120,6 @@ function getStream(opt) {
   });
 
   return ret;
-
-  function rename(file) {
-    return file;
-  }
 }
 
 function chooseParseType(jsStream, cssStream) {

diff --git a/lib/util.js b/lib/util.js
@@ -133,9 +133,9 @@ function throwError() {
 
 function getRenameOpts(file, opts) {
   if (typeof opts === 'function') {
-    return opts;
+    return opts.bind(null, file);
   }
-  
+
   opts = opts || {};
   var ret = {suffix: ''};
   if (opts.hash) {

diff --git a/test/transport.test.js b/test/transport.test.js
@@ -302,7 +302,10 @@ describe('Transport', function() {
       var opt = {
         cwd: cwd,
         moduleDir: 'sea-modules',
-        rename: {hash:true}
+        rename: function(file, fileObj) {
+          fileObj.suffix = '-' + file.hash;
+          return fileObj;
+        }
       };
 
       vfs.src('index.js', {cwd: cwd, cwdbase: true})