Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(js) return window.xx if not contain window. when global #27

Merged
merged 1 commit into from
Jan 16, 2015

Conversation

popomore
Copy link
Member

No description provided.

sorrycc added a commit that referenced this pull request Jan 16, 2015
feat(js) return window.xx if not contain `window.` when global
@sorrycc sorrycc merged commit d89e4d1 into master Jan 16, 2015
@sorrycc sorrycc deleted the prefix-window branch January 16, 2015 07:49
@popomore
Copy link
Member Author

如果遇到 --globa jquery:this.$ 就会有问题,不过没人这么写吧

@afc163
Copy link
Member

afc163 commented Jan 16, 2015

: 后面的只能是标准变量吧,对特殊字符要校验下,这种 this.$ 直接就报错?

@popomore
Copy link
Member Author

校验 . 么

@afc163
Copy link
Member

afc163 commented Jan 16, 2015

校验变量名

@popomore
Copy link
Member Author

其实是有场景的,比如要用 ajax,原来用到 ajax 模块,但是这个 ajax 和 jq 的 ajax 是一样的。

var ajax = require('ajax')

所以可以这样 --globa ajax:jQuery.ajax

@hotoo
Copy link
Member

hotoo commented Jan 17, 2015

feat(xxx) 是什么注释风格?

@popomore
Copy link
Member Author

抄 angular 的

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants