Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stream #4

Merged
merged 30 commits into from
Jul 16, 2014
Merged

Stream #4

merged 30 commits into from
Jul 16, 2014

Conversation

popomore
Copy link
Member

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-5.73%) when pulling e40859b on stream-all into 24c2f21 on master.

@sorrycc
Copy link
Member

sorrycc commented Jul 2, 2014

buildJSDebug 报错,找不到 index-debug.js

     Uncaught Error in plugin 'getFileInfo'
not found index-debug.js of pkg a@1.0.0
      at getFileInfo (/Users/chencheng/Documents/Work/Libraries/alipay/spmjs/gulp-transport/lib/common.js:190:13)
      at replace (/Users/chencheng/Documents/Work/Libraries/alipay/spmjs/gulp-transport/lib/parser/js.js:51:15)
      at parser (/Users/chencheng/Documents/Work/Libraries/alipay/spmjs/gulp-transport/lib/parser/js.js:28:19)
      at Transform._transform (/Users/chencheng/Documents/Work/Libraries/alipay/spmjs/gulp-transport/lib/common.js:222:14)

@sorrycc
Copy link
Member

sorrycc commented Jul 3, 2014

  1. css 需要处理 rename
  2. css2js 时,如果 css 有 @import 其他 css,define 里不应该有依赖项

@popomore
Copy link
Member Author

@sorrycc
Copy link
Member

sorrycc commented Jul 15, 2014

两个问题:

  1. common.jsL276 pkg.dependencies = deps; 报错

    TypeError: Cannot set property dependencies of #<SubClass> which has only a getter
    at /Users/chencheng/Documents/Work/Libraries/alipay/spmjs/gulp-transport/lib/common.js:276:22
    
  2. umi/standalonify.js 里调用了 gulp-transport 里的 transportId,接口改了后 undefined 了

@popomore
Copy link
Member Author

Father 的要升级下—
Sent from Mailbox for iPhone

On Tue, Jul 15, 2014 at 4:55 PM, chencheng (云谦) notifications@github.com
wrote:

两个问题:

  1. common.jsL276 pkg.dependencies = deps; 报错

TypeError: Cannot set property dependencies of # which has only a getter
at /Users/chencheng/Documents/Work/Libraries/alipay/spmjs/gulp-transport/lib/common.js:276:22

2. umi/standalonify.js 里调用了 gulp-transport 里的 transportId,接口改了后 undefined 了
---
Reply to this email directly or view it on GitHub:
https://github.com/popomore/gulp-transport/pull/4#issuecomment-49006190

@sorrycc
Copy link
Member

sorrycc commented Jul 15, 2014

ok, 1 好了,还剩 2 。

-- 
chencheng
Sent with Airmail

On July 15, 2014 at 5:53:16 PM, Haoliang Gao (notifications@github.com) wrote:

Father 的要升级下—
Sent from Mailbox for iPhone

On Tue, Jul 15, 2014 at 4:55 PM, chencheng (云谦) notifications@github.com
wrote:

两个问题:

  1. common.jsL276 pkg.dependencies = deps; 报错
TypeError: Cannot set property dependencies of #<SubClass> which has only a getter
at /Users/chencheng/Documents/Work/Libraries/alipay/spmjs/gulp-transport/lib/common.js:276:22

2. umi/standalonify.js 里调用了 gulp-transport 里的 transportId,接口改了后 undefined 了

Reply to this email directly or view it on GitHub:
#4 (comment)

Reply to this email directly or view it on GitHub.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.23%) when pulling aebc1dd on stream-all into 26bbda2 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.23%) when pulling a263e65 on stream-all into 26bbda2 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.23%) when pulling 373cea0 on stream-all into 26bbda2 on master.

popomore added a commit that referenced this pull request Jul 16, 2014
@popomore popomore merged commit 9c34040 into master Jul 16, 2014
@popomore popomore deleted the stream-all branch July 16, 2014 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants