Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed non working Modt/description #3

Merged
merged 2 commits into from
Jan 20, 2022
Merged

Fixed non working Modt/description #3

merged 2 commits into from
Jan 20, 2022

Conversation

TheKingDave
Copy link
Contributor

The library used the wrong key. "description" instead of "text".

spnda
spnda requested changes Jan 20, 2022
View reviewed changes
Copy link
Owner

@spnda spnda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, would you mind quickly also changing the test (test/ping_test.dart) so that it checks for MOTDs? I'll merge this right after!

@TheKingDave
Copy link
Contributor Author

Added the test for MODT
Thanks for the quick reply

spnda
spnda approved these changes Jan 20, 2022
View reviewed changes
Copy link
Owner

@spnda spnda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@spnda spnda merged commit 05d1b8d into spnda:main Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spnda spnda spnda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TheKingDave @spnda