Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow time requests > 255s #2

Open
spohorec opened this issue Dec 9, 2023 · 0 comments · May be fixed by #5
Open

Allow time requests > 255s #2

spohorec opened this issue Dec 9, 2023 · 0 comments · May be fixed by #5
Assignees

Comments

@spohorec
Copy link
Owner

spohorec commented Dec 9, 2023

Currently time set command take one uint8 as a parameter for the number of seconds. This constrains the time to being 4m25s or less. 5min time can be desirable for rumbles, etc. Allow time up to 9m59 by updating the command structure to have 2 bytes of parameter.

@spohorec spohorec self-assigned this Dec 9, 2023
@spohorec spohorec linked a pull request Dec 9, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant