Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add actual result checks to test suite #63

Closed
egpbos opened this issue Jan 13, 2021 · 2 comments
Closed

Add actual result checks to test suite #63

egpbos opened this issue Jan 13, 2021 · 2 comments
Assignees
@cwmeijer
Labels
software sustainability

Comments

@egpbos
Copy link
Collaborator

egpbos commented Jan 13, 2021

Currently, our CI test suite of running experiments is only a "smoke test", i.e. it checks only whether everything runs, but not if it runs correctly. We should add result value checks so that we can see when changes in code change model outcomes.
@bhigy
Copy link
Contributor

bhigy commented Feb 4, 2021

To do after #33.

@cwmeijer cwmeijer self-assigned this Feb 16, 2021
cwmeijer added a commit that referenced this issue Feb 16, 2021
@cwmeijer
add asserts for results in experiment tests (refs #63)
7c3a5ca
@cwmeijer cwmeijer mentioned this issue Feb 23, 2021
Closed
cwmeijer added a commit that referenced this issue Mar 2, 2021
@cwmeijer
fix tests while maintaining sensible result returns
8493c37 
The challenge here is to have the experiments return sensible results for the
user while also meaningfull to test against (sensitive to code/logic changes).
This commit manages to do this for most tests. refs #63
cwmeijer added a commit that referenced this issue Mar 2, 2021
@cwmeijer
add meaningful test results to transformer and basic tests (refs #63)
c11800f
cwmeijer added a commit that referenced this issue Mar 2, 2021
@cwmeijer
add approximate checking in experiment tests (refs #63)
9dbca8b
cwmeijer added a commit that referenced this issue Mar 2, 2021
@cwmeijer
add pandas to test environment (refs #63)
087cc01
cwmeijer added a commit that referenced this issue Mar 3, 2021
@cwmeijer
rename step_loss, added average_loss to all experiments (ref #63)
584d6f3
@cwmeijer
Copy link
Contributor

cwmeijer commented Mar 8, 2021

fixed in #78

@cwmeijer cwmeijer closed this as completed Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cwmeijer cwmeijer

Labels
software sustainability
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cwmeijer @egpbos @bhigy