-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: start adding Transformer based audio encoder #3
Conversation
It works now (on my machine and on CI), suggestions / comments very welcome. |
Also implemented the optional config parameters scheme I suggested in #5. |
Codecov Report
@@ Coverage Diff @@
## master #3 +/- ##
==========================================
+ Coverage 45.56% 46.15% +0.58%
==========================================
Files 12 12
Lines 812 858 +46
==========================================
+ Hits 370 396 +26
- Misses 442 462 +20
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on our recent discussion, I reverted the move of epochs
from the experiment to the global config, as it doesn't make sense for some scripts (e.g. the utilities). We could create a function somewhere to add to the parser all experiment parameters that are generic like this one.
Ok, thanks for the review! Applied your suggestions, merging now so I can train based on this model. |
I just started a very rough first implementation, it's not working yet, but I'll just keep updating it in this work-in-progress PR.