Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: start adding Transformer based audio encoder #3

Merged
merged 9 commits into from
May 1, 2020

Conversation

egpbos
Copy link
Collaborator

@egpbos egpbos commented Mar 13, 2020

I just started a very rough first implementation, it's not working yet, but I'll just keep updating it in this work-in-progress PR.

@egpbos
Copy link
Collaborator Author

egpbos commented Apr 8, 2020

It works now (on my machine and on CI), suggestions / comments very welcome.

@egpbos
Copy link
Collaborator Author

egpbos commented Apr 8, 2020

Also implemented the optional config parameters scheme I suggested in #5.

@egpbos egpbos marked this pull request as ready for review April 8, 2020 10:19
@egpbos egpbos requested a review from bhigy April 8, 2020 10:19
@codecov-io
Copy link

codecov-io commented Apr 8, 2020

Codecov Report

Merging #3 into master will increase coverage by 0.58%.
The diff coverage is 95.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
+ Coverage   45.56%   46.15%   +0.58%     
==========================================
  Files          12       12              
  Lines         812      858      +46     
==========================================
+ Hits          370      396      +26     
- Misses        442      462      +20     
Impacted Files Coverage Δ
platalea/encoders.py 26.81% <92.68%> (+3.15%) ⬆️
experiments/basic-stack-trafo/run.py 100.00% <100.00%> (ø)
platalea/basic.py 87.20% <0.00%> (ø)
experiments/basic-stack/run.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70f50a3...259809b. Read the comment docs.

Copy link
Contributor

@bhigy bhigy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on our recent discussion, I reverted the move of epochs from the experiment to the global config, as it doesn't make sense for some scripts (e.g. the utilities). We could create a function somewhere to add to the parser all experiment parameters that are generic like this one.

platalea/encoders.py Outdated Show resolved Hide resolved
platalea/encoders.py Outdated Show resolved Hide resolved
@egpbos
Copy link
Collaborator Author

egpbos commented May 1, 2020

Ok, thanks for the review! Applied your suggestions, merging now so I can train based on this model.

@egpbos egpbos merged commit e6b8adf into master May 1, 2020
@egpbos egpbos deleted the speech_encoder_trafo branch July 27, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants